Skip to content

fix: notification list HTTP 500 and add --all flag (#109)#124

Merged
q-soriarty merged 1 commit intodevelopfrom
fix/109-notification-list
Apr 2, 2026
Merged

fix: notification list HTTP 500 and add --all flag (#109)#124
q-soriarty merged 1 commit intodevelopfrom
fix/109-notification-list

Conversation

@q-soriarty
Copy link
Copy Markdown
Contributor

Summary

Closes #109

Root cause

Copia/Gitea returns HTTP 500 on GET /api/v1/notifications without any query parameters. Adding ?page=1 works around this server-side bug.

Additional fix

Added --all flag to show both read and unread notifications (passes ?all=true to API). Without this flag, only unread notifications are shown (Gitea default).

Investigation

GET /notifications           → 500
GET /notifications?page=1    → 200 (unread only)
GET /notifications?page=1&all=true → 200 (all notifications)

Test plan

  • TestListRun_Success — list unread notifications
  • TestListRun_Empty — empty list message
  • TestListRun_AllFlag — --all shows read notifications
  • All existing tests pass

Copia/Gitea returns 500 on GET /notifications without query params.
Adding ?page=1 works around the server-side bug. Also adds --all
flag to show read and unread notifications (default: unread only).
@q-soriarty q-soriarty marked this pull request as ready for review April 2, 2026 10:51
@q-soriarty q-soriarty merged commit 3717d80 into develop Apr 2, 2026
4 checks passed
@q-soriarty q-soriarty deleted the fix/109-notification-list branch April 2, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant