-
Notifications
You must be signed in to change notification settings - Fork 149
updated Qvault SC #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TakaYuPP
wants to merge
72
commits into
qubic:develop
Choose a base branch
from
TakaYuPP:qvaultV2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
updated Qvault SC #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-callback Feature/2025 03 25 incoming transfer callback
…r-callback Feature/2025 03 25 incoming transfer callback
…r-callback Feature/2025 03 25 incoming transfer callback
Contributor
|
Looks like a completely new code for QVAULT. Make sure you ask comps permission to upgrade, and write a tutorial how to migrate the state from old to new SC, if needed |
Fix build problems
Extend transferShareOwnershipAndPossession() to support burning of asset shares by transferring to NULL_ID. Burning contract shares is forbidden.
Add burning of asset shares
Even if the contract stack is not needed for storing locals, inputs, or outputs directly when starting a system procedure, it may be needed by nested calls of QPI / procedures / functions. So we always need to reserve a contract stack.
…r-all-system-proc Bugfix/2025 05 04 contract stack for all system proc
Gruekan
reviewed
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QVAULT UPDATE:
Here is the list of each type of proposal:
• QCAP general proposal
• Quorum requirement
• IPO participation
• Qearn participation
• Fundraising proposal
• Marketplace proposal
• Allocation percentage
Each proposal will cost 10M $QUBIC, vote will be closed 30 minutes before change of epoch. Any proposal launched during that 30 minutes period will be suspended and go live at the beginning of new epoch.
To create a proposal each individual must have either 10,000 $QCAP staked or 1 $QVAULT in possession. Only the ID that have $QCAP staked (from last epoch) are allowed to participate. A vote is considered valid only if it reaches quorum requirement.
QCAP general proposal:
Those proposal are simple and have no impact on the investment made by QCAP. The type of vote I expect are election of admin or team member, it can also be to gauge sentiment.
Quorum requirement:
This proposal is used to adjust the requirement for a proposal to be considered valid. For now, set it at 50% but the value can be between 1/3 (33.33%) and ½ (50%). The quorum requirement is calculated based of the amount of $QCAP staked.
IPO participation:
People submit a proposal to participate in XYZ IPO, people then vote how much they want to invest (numeral value). QVAULT then at the end calculate the weighted average, meaning that someone holding 10,000 $QCAP will have more 10 times more power than someone holding 1,000 $QCAP. Make sure that someone submitting his number can’t be higher than the amount of Qubic held by the smart contract.
Qearn participation:
People will submit a proposal: Invest 1B per epoch for the next 10 epochs. People will then vote yes or no. If approved QVAULT SC will set aside 10b and lock it during the next 10 weeks. Once the 52 epoch is over, Qearn will send back 1b plus interest, we need to make sure that only the interest is distributed (revenue) and the 1B (capital) is kept inside QVAULT.
Fundraising proposal:
People will submit a proposal such as sell 100,000 $QCAP at 1,000,000 Qubic. If approved, QVAUT will allow the sale of those token. The Qubic raised from this proposal are not considered as revenues and should not be distributed. We also need to respect the availability f $QCAP (tokenomic). In 2025 a maximum of 10,714,286 $QCAP can be sold, 2026 15,571,429 $QUBIC, 2027 18,000,000 $QUBIC and after that the last 3,000,000 can be sold anytime.
Marketplace proposal:
Someone will come and say I want to sell 10 Quottery and 1 Qx for 10b Qubic and 10,000 $QCAP. He then sends the assets to QVAULT for the proposal to go live. If approved by the quorum, the ID shall receive, 10b Qubic and 10,000 $QCAP if not approved QVAULT should send back the SC shares to the ID. If by any chance QVAULT does not have enough fund (Qubic or all QCAP sold for a specific year), the seller should get back his shares.
Allocation percentage:
Someone will make a proposal to change the percentage of allocation. The possibilities are reinvested, distributed, team, burned and QVAULT. QVAULT revenue is locked at 3% forever. This means that the other categories must equal always 97%. Currently the team earns 2%, on the 1st January of 2027 the team fee will go to 0% and the 2% will transferred to revenue distribution. We need to make sure that the fee for the team can never be put again to a value need to stay to 0% forever.
Fund management:
Since all poll will end at the same time it will happen that QVAULT can’t follow all proposal. The rule is simple priority to IPO, then marketplace, then Qearn.
If we have 100b and we had 2 IPO, 1 market place proposal and 1 Qearn proposal here is how it should go.
IPO 1: invest 50b
IPO 2: invest 30b
Marketplace: Buy 1 Qx for 10b
Qearn: Lock 1b for the next 20 epochs
Result would be as followed: QVAULT would invest 50b in IPO 1, 30b in IPO 2, Buy 1 Qx for 10b and lock 1b for the next 10 epochs.
New case we have 100b:
IPO 1: Invest 80b
IPO 2: Invest 50b
Qearn: Lock 1b for the next 10 epochs
Result are:
IPO 1: 61.54b = [80/(80+50)] * 100
IPO 2: 38.46b = [50/(80+50)] * 100
Qearn: 0b.
Other features needed:
• Display data needed.
muslim people don't want to receive the revenue from specific share like Quottery. so it will be excluded in distribution for muslim people.
https://github.com/TakaYuPP/qubic-stateFile-migration-QVAULT-SC--tool