Skip to content

feat: test decimal #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: test decimal #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3078928
feat: test decimal
RaphDal Oct 13, 2025
1aaa3f9
tests: add minimum protocol version to decimal test
RaphDal Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 52 additions & 7 deletions ilp-client-interop-test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
],
"result": {
"status": "SUCCESS",
"binaryBase64": "dGVzdF90YWJsZSxzeW1fY29sPXN5bV92YWwgc3RyX2NvbD0iZm9vIGJhciBiYXoiLGxvbmdfY29sPTQyaSxkb3VibGVfY29sPT0QAAAAAABARUAsYm9vbF9jb2w9dAo=",
"line": "test_table,sym_col=sym_val str_col=\"foo bar baz\",long_col=42i,double_col=42.5,bool_col=t"
}
},
Expand Down Expand Up @@ -73,6 +74,7 @@
],
"result": {
"status": "SUCCESS",
"binaryBase64": "ZG91YmxlcyBkMD09EAAAAAAAAAAALGRtMD09EAAAAAAAAACALGQxPT0QAAAAAAAA8D8sZEUxMDA9PRB9w5QlrUmyVCxkMDAwMDAwMT09EI3ttaD3xrA+LGROMDAwMDAwMT09EI3ttaD3xrC+Cg==",
"anyLines": [
"doubles d0=0,dm0=-0,d1=1,dE100=1E+100,d0000001=1E-06,dN0000001=-1E-06",
"doubles d0=0.0,dm0=-0.0,d1=1.0,dE100=1e100,d0000001=1e-6,dN0000001=-1e-6",
Expand Down Expand Up @@ -1639,15 +1641,58 @@
"testName": "quote in symbol value",
"table": "quote",
"symbols": [
{
"name": "sym",
"value": "\"val\""
}
{
"name": "sym",
"value": "\"val\""
}
],
"columns": [],
"result": {
"status": "SUCCESS",
"line": "quote,sym=\"val\""
"status": "SUCCESS",
"line": "quote,sym=\"val\""
}
},
{
"testName": "decimal",
"minimumProtocolVersion": 3,
"table": "decimals",
"symbols": [],
"columns": [
{
"type": "DECIMAL",
"name": "zero",
"value": "0.0"
},
{
"type": "DECIMAL",
"name": "neg_zero",
"value": "-0.0"
},
{
"type": "DECIMAL",
"name": "one",
"value": "1.0"
},
{
"type": "DECIMAL",
"name": "large",
"value": "99999999999999.999"
},
{
"type": "DECIMAL",
"name": "small",
"value": "0.001"
},
{
"type": "DECIMAL",
"name": "neg_small",
"value": "-0.001"
}
],
"result": {
"status": "SUCCESS",
"line": "decimals zero=0d,neg_zero=0d,one=1.0d,large=99999999999999.999d,small=0.001d,neg_small=-0.001d",
Copy link
Collaborator

@ideoma ideoma Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any programming language where d suffix means decimal and not double?

Copy link
Author

@RaphDal RaphDal Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know of one, but ILP isn't a programming language and m was already used for millisecond timestamps. Also, there is no reason d would be used for doubles in the future as any numeric literals are doubles by default.

Copy link
Collaborator

@ideoma ideoma Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d is confusing; I'd rather have any other unused letter. Type suffixes in ILP work when a new column has to be created; they determine the column type.

Copy link
Author

@RaphDal RaphDal Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type suffixes in ILP work when a new column has to be created; they determine the column type.

Yes, they do.

d is confusing; I'd rather have any other unused letter.

If it's not related to the test but to the format, let's continue the discussion here.

"binaryBase64": "ZGVjaW1hbHMgemVybz09FwEBACxuZWdfemVybz09FwEBACxvbmU9PRcBAQosbGFyZ2U9PRcDCAFjRXhdif//LHNtYWxsPT0XAwEBLG5lZ19zbWFsbD09FwMB/wo="
}
}
]
]