run-test262: handle scandir() results with DT_UNKNOWN d_type #1104
+29
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the dirent items returned by scandir() have DT_UNKNOWN as d_type it is not possible to assume they are "non directories", and it is needed to stat() them to get the actual type. Hence, tweak the existing bits to account for that: - create an helper enum for file type to distinguish whether something is for sure a file, whether it is for sure a directory, or it is not known - map d_type to the newly created enum - adapt consider_test_file() to use the newly created enum, and case the file type is not known also to stat() the file to get the actual type On Windows the file type is always known, so there is no need to stat() files.
pinotree
force-pushed
the
run-test262-dt_unknown
branch
from
8b44259 to
11cf91b
Compare
|
Out of curiosity, what files do you have that require filtering out? |
This is not about filtering, but rather collecting the tests to run using |
|
Yes, I know that. What I mean, is, what did you have in there which results in DT_UNKNOWN? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the
direntitems returned byscandir()haveDT_UNKNOWNasd_typeit is not possible to assume they are "non directories", and it is needed tostat()them to get the actual type.Hence, tweak the existing bits to account for that:
d_typeto the newly created enumconsider_test_file()to use the newly created enum, and case the file type is not known also tostat()the file to get the actual typeOn Windows the file type is always known, so there is no need to
stat()files.