Work branch by qusai122 · Pull Request #1 · qusai122/Review-my-code

qusai122 · 2023-02-22T10:57:06Z

start my project

qusai122 · 2023-02-22T10:59:50Z

Good job so far! 👍
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Kindly check the inline comments under the review. ⬇️

To Highlights

✔️ No linter error.
✔️ Proper Github flow used.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

The commit message should be written in the imperative tense and the first letter should also be capitalized. Ex: " Creat index file " creat index file". For more details...

Cheers and Happy coding!👏👏👏

qusai122 · 2023-02-22T11:00:30Z

try to provide a good PR title & description.

qusai122 · 2023-02-22T11:01:37Z

describe your project in 1 or 2 sentences, and your read-me should follow the template.

didierganthier

Hi @qusai122 ,

🎉 Good job so far! You're making great progress on this project, but there are still a few areas that need attention before we can move on to the next step.

Highlights

Added 2 comments ✔️
Showed highlights ✔️

Required Changes 🛠

Well done overall 🚀 but you should submit a review in the Pull Request utilizing the "Review changes" feature from GitHub. You can learn here
Nice work on the comments 🗨️ but you should use the GitHub inline comments feature at least once to leave review comments 😉
The 2 comments added are good 💯 but make sure to actually explain why you request the changes and make it sound like a suggestion instead of an order. 🙂
Please review the comments under the review for specific changes that still need to be made.

Optional Suggestions 💡

While these comments with the [OPTIONAL] prefix won't prevent the approval of this pull request, I strongly recommend taking them into account as they can improve your code.

🚀 Keep pushing forward, you're almost there! If you have any questions or need clarification on anything, feel free to leave a comment in the pull request thread and don't forget to tag me so I'll receive the notification.

Please note

To avoid confusion and delays, please do not open a new pull request for re-reviews. Use the same pull request submitted for the first review, unless otherwise instructed.

As per the Code reviews limits policy, you have a limited number of reviews per project. If you feel that the code review was unfair, you can request a second opinion using this form.

Cheers and happy coding! 👏👏👏

qusai122

Good job so far! 👍
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️
Kindly check the inline comments under the review. ⬇️
To Highlights
✔️ No linter error.
✔️ Proper Github flow used.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

The commit message should be written in the imperative tense and the first letter should also be capitalized. Ex: " Creat index file " creat index file". For more details...
Cheers and Happy coding!👏👏👏

qusai122 · 2023-02-27T15:01:11Z

index.html

@@ -0,0 +1,148 @@
+


we can't see the readme file, kindly Fix that.

qusai122 · 2023-02-27T15:03:11Z

index.html

+      <section id="hero">
+        <h2>Handcrafted,home-made masterpieces</h2>
+        <form id="form" action="https://www.freecodecamp.com/email-submit">
+          <input


We asked for username input also, but I think you forget about it.

qusai122 · 2023-02-27T15:04:14Z

style.css

+  width: 60vw;
+}
+
+@media (max-width: 650px) {


max-width should be 750 px

brainconnect93

STATUS: Changes Required ♻️

Hi @qusai122, 👋

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

To Highlight 🥇

Has a proper Pull Request. ✔️
No Linter errors ✔️
Good use of Github flow ✔️

Changes Required

A requested by the previous reviewer, kindly give reason WHY you are requested the changes and should be inform of a suggestion rather than been an order
- N.B:
  1. The student always includes an explanation, a "why", for each requested change. For example: This is a well-explained request: Why don't you use an article tag for the .first-article element instead of a div, that would improve the HTML structure and make the page more accessible.
  2. The student phrased the comments politely, as suggestions instead of orders. For example: This is a polite suggestion: *"I think it would be better to use semantic tags"
    This reads as an order: *"Use semantic tags"

This request lacks a "why": Why don't you use an article tag here instead of a div?

Please check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me on( @brainconnect93 ) in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

qusai122

Good job so far! 👍
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Kindly check the inline comments under the review. ⬇️
We can't see your readme file, probably because you merged it.

To Highlights

✔️ No linter error.
✔️ Proper Github flow used.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

The commit message should be written in the imperative tense and the first letter should also be capitalized. Ex: " Creat index file " creat index file". For more details...

Cheers and Happy coding!👏👏👏

qusai122 · 2023-03-01T18:56:51Z

index.html

+    <meta name="viewport" content="width=device-width, initial-scale=1.0">
+    <link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.0-alpha1/dist/css/bootstrap.min.css" rel="stylesheet">
+    <title>Document</title>
+    <link rel="stylesheet" href="style.css" />


kindly on this line of code! please include the given CSS through the stylesheet file because it will make your code professional and clear to anyone!

qusai122 · 2023-03-01T18:58:23Z

index.html

+      <section id="hero">
+        <h2>Handcrafted,home-made masterpieces</h2>
+        <form id="form" action="https://www.freecodecamp.com/email-submit">
+          <input


kindly add a user name input because it is a requirement.

qusai122 · 2023-03-01T19:00:17Z

style.css

+  width: 60vw;
+}
+
+@media (max-width: 650px) {


kindly fix the max width it's better to be 750px to match the project,

because some phones have a bigger width.

Cheers and Happy coding!👏👏👏

binhussen

Hi @qusai122 ,

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Highlights

All linter checks passed ✔️
Descriptive pull request ✔️
Used GitHub flow ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

qusai122 added 2 commits February 22, 2023 12:55

creat indx file

3924db0

fix index and upload style

787fdef

didierganthier suggested changes Feb 27, 2023

View reviewed changes

This comment was marked as duplicate.

Sign in to view

qusai122 commented Feb 27, 2023

View reviewed changes

brainconnect93 suggested changes Feb 27, 2023

View reviewed changes

qusai122 commented Mar 1, 2023

View reviewed changes

binhussen approved these changes Mar 1, 2023

View reviewed changes

Conversation

qusai122 commented Feb 22, 2023

Uh oh!

qusai122 commented Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Required Changes ♻️

To Highlights

Optional suggestions

Uh oh!

qusai122 commented Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qusai122 commented Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

didierganthier left a comment

Choose a reason for hiding this comment

Highlights

Required Changes 🛠

Optional Suggestions 💡

Uh oh!

This comment was marked as duplicate.

Uh oh!

qusai122 left a comment

Choose a reason for hiding this comment

Uh oh!

qusai122 Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

qusai122 Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

qusai122 Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

brainconnect93 left a comment

Choose a reason for hiding this comment

STATUS: Changes Required ♻️

Hi @qusai122, 👋

To Highlight 🥇

Changes Required

Optional suggestions

Uh oh!

qusai122 left a comment

Choose a reason for hiding this comment

Required Changes ♻️

To Highlights

Optional suggestions

Uh oh!

qusai122 Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qusai122 Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qusai122 Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

binhussen left a comment

Choose a reason for hiding this comment

Highlights

Optional suggestions

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

qusai122 commented Feb 22, 2023 •

edited

Loading

qusai122 commented Feb 22, 2023 •

edited

Loading

qusai122 commented Feb 22, 2023 •

edited

Loading

qusai122 Mar 1, 2023 •

edited

Loading

qusai122 Mar 1, 2023 •

edited

Loading

qusai122 Mar 1, 2023 •

edited

Loading