Skip to content

Check if tests are coupled #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Check if tests are coupled #1938

wants to merge 29 commits into from
+37 −1

Conversation

@IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Mar 26, 2023

cf. #1937

@codecov-commenter

This comment was marked as off-topic.

Sign in to view
@IndrajeetPatil
Copy link
Collaborator Author

IndrajeetPatil commented Mar 26, 2023

Looks like there is some order dependence between our tests.

@MichaelChirico

This comment was marked as outdated.

Sign in to view
@MichaelChirico MichaelChirico mentioned this pull request Apr 8, 2023
Merged
@MichaelChirico

This comment was marked as outdated.

Sign in to view
@MichaelChirico

This comment was marked as outdated.

Sign in to view
@IndrajeetPatil

This comment was marked as outdated.

Sign in to view
@AshesITR
Copy link
Collaborator

AshesITR commented Apr 19, 2023

I'd suggest putting the script into .dev instead of inline.
This would also allow adding convenience features such as a command line argument for a static seed when trying to debug a failure.

@Bisaloo Bisaloo mentioned this pull request Sep 26, 2023
Merged
@IndrajeetPatil IndrajeetPatil mentioned this pull request May 6, 2024
Merged
1 task
@IndrajeetPatil IndrajeetPatil added the internals Issues related to inner workings of lintr, i.e., not user-visible label Jun 7, 2024
@MichaelChirico
Copy link
Collaborator

MichaelChirico commented Nov 15, 2025

it looks like shuffle=TRUE is designed to make this trivial to test:

https://tidyverse.org/blog/2025/11/testthat-3-3-0/

@IndrajeetPatil
Copy link
Collaborator Author

IndrajeetPatil commented Nov 15, 2025

Yes :)

r-lib/testthat#1942

@IndrajeetPatil
Copy link
Collaborator Author

IndrajeetPatil commented Nov 15, 2025

The failing tests with testthat 3.3.0 are expected to fail (cf. #2937). The incompatibility needs to be resolved in a separate PR.

@IndrajeetPatil
Copy link
Collaborator Author

IndrajeetPatil commented Nov 16, 2025

@MichaelChirico Took only 3 years but the builds are now passing 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

internals Issues related to inner workings of lintr, i.e., not user-visible testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IndrajeetPatil @codecov-commenter @MichaelChirico @AshesITR