Skip to content

feat(messaging): v1 #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
f-gate wants to merge 42 commits into
base: main
Choose a base branch
from
Open

feat(messaging): v1 #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
b7cd6f5
pull over relevant files
f-gate Feb 26, 2025
e7b234b
fix compilation
f-gate Feb 27, 2025
5d169c3
pull over relevant files
f-gate Mar 10, 2025
37a89c2
fix compilation
f-gate Mar 10, 2025
e82bc6d
messaging mock impl
f-gate Mar 10, 2025
59189a1
query status refactor, fix stuck deposits, write first test
f-gate Mar 10, 2025
d397550
remove tests 1
f-gate Mar 10, 2025
12b745a
refactor remove extrinsic for better testing
f-gate Mar 10, 2025
16be260
second refactor, much better
f-gate Mar 10, 2025
e0b2e21
fmt
f-gate Mar 10, 2025
3e916f8
fmt, fixes, test, benchmark
f-gate Mar 10, 2025
1282743
refactor storage deposits
f-gate Mar 10, 2025
789096f
check warnings
f-gate Mar 10, 2025
e0e6860
fmt
f-gate Mar 10, 2025
b4c67d9
Off chain and on chain byte fees
f-gate Mar 10, 2025
a7e3558
fmt
f-gate Mar 10, 2025
e193b0c
comments
f-gate Mar 10, 2025
855ab4f
remove useless test
f-gate Mar 10, 2025
eb6ad29
fmt
f-gate Mar 10, 2025
ceaeab4
defensive
f-gate Mar 10, 2025
3f04120
fmt
f-gate Mar 10, 2025
22776ca
fix storage deposit
f-gate Mar 10, 2025
3f07f3c
use ok_or
f-gate Mar 11, 2025
26b8e4b
Merge branch 'messaging-general' of github.com:f-gate/pop-node into m…
f-gate Mar 17, 2025
1f01c3a
fix
f-gate Mar 17, 2025
2fea60e
Merge branch 'main' of github.com:r0gue-io/pop-node into messaging-base
f-gate Mar 17, 2025
8ceb523
fix
f-gate Mar 17, 2025
83bd4cb
Messaging: XCM (#501)
f-gate Mar 25, 2025
8975a8f
Messaging CallbackExecutor (#502)
f-gate Apr 1, 2025
45082d8
Messaging ismp core (#506)
f-gate Apr 3, 2025
e93a870
Merge branch 'main' of github.com:r0gue-io/pop-node into messaging-base
f-gate Apr 7, 2025
b6788ec
Refund any unused callback weight (#505)
f-gate Apr 9, 2025
5f3a749
Merge branch 'messaging-base' of github.com:r0gue-io/pop-node into me…
f-gate Apr 15, 2025
5887d71
chore(messaging): messaging runtime weights (#510)
f-gate Apr 17, 2025
e0f3981
chore(messaging): take fee for response (#509)
f-gate Apr 21, 2025
ff93137
feat(messaging): release callback deposits for timedout messages (#512)
f-gate Apr 23, 2025
c2fb2bf
feat(messaging): callback gas topup (#515)
f-gate Apr 24, 2025
e10c561
chore(messaging): final weight revision (#527)
f-gate Apr 25, 2025
cb9c0ca
weights.md
f-gate Apr 25, 2025
7fc6ddf
mermaid
f-gate Apr 28, 2025
4735b2a
chore(messaging): use an unbalanced handler instead of naive transfer…
f-gate Apr 29, 2025
569d6b7
bug(messaging): Handle additional static weight outside callback func…
f-gate Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11,481 changes: 3,608 additions & 7,873 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

26 changes: 24 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ exclude = [
"extension/contract",
"pop-api",
"tests/contracts",
"integration-tests",
Copy link
Collaborator

@evilrobot-01 evilrobot-01 May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description shows integration tests as a 'completed' todo, yet they are excluded?

]
members = [
"integration-tests",
"node",
"pallets/*",
"pop-api/integration-tests",
#"pop-api/integration-tests",
Copy link
Collaborator

@evilrobot-01 evilrobot-01 May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously cant merge into main until this is resolved. There is no corresponding todo in the PR description.

"primitives",
"runtime/devnet",
"runtime/mainnet",
Expand Down Expand Up @@ -148,6 +148,7 @@ sp-session = { git = "https://github.com/paritytech/polkadot-sdk", branch = "sta
sp-std = { git = "https://github.com/paritytech/polkadot-sdk", branch = "stable2412", default-features = false }
sp-timestamp = { git = "https://github.com/paritytech/polkadot-sdk", branch = "stable2412" }
sp-transaction-pool = { git = "https://github.com/paritytech/polkadot-sdk", branch = "stable2412", default-features = false }
sp-weights = { git = "https://github.com/paritytech/polkadot-sdk", branch = "stable2412", default-features = false }
sp-version = { git = "https://github.com/paritytech/polkadot-sdk", branch = "stable2412", default-features = false }
substrate-frame-rpc-system = { git = "https://github.com/paritytech/polkadot-sdk", branch = "stable2412" }

Expand Down Expand Up @@ -205,3 +206,24 @@ ismp-parachain-runtime-api = { git = "https://github.com/r0gue-io/ismp", branch
pallet-ismp = { git = "https://github.com/r0gue-io/ismp", branch = "polkadot-stable2412", default-features = false }
pallet-ismp-rpc = { git = "https://github.com/r0gue-io/ismp", branch = "polkadot-stable2412", default-features = false }
pallet-ismp-runtime-api = { git = "https://github.com/r0gue-io/ismp", branch = "polkadot-stable2412", default-features = false }

# Revive
Copy link
Collaborator

@evilrobot-01 evilrobot-01 May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed after a rebase please?

# array-bytes = { version = "6.2.2", default-features = false }
# assert_matches = { version = "1.5.0" }
# bitflags = { version = "1.3.2" }
# environmental = { version = "1.1.4", default-features = false }
# pallet-revive-fixtures = { path = "pallets/revive/fixtures", default-features = false }
# pallet-revive-mock-network = { default-features = false, path = "pallets/revive/mock-network" }
# pallet-revive-proc-macro = { path = "pallets/revive/proc-macro", default-features = false }
# pallet-revive-uapi = { path = "pallets/revive/uapi", default-features = false }
# parity-wasm = { version = "0.45.0" }
# paste = { version = "1.0.14", default-features = false }
# pretty_assertions = { version = "1.3.0" }
# proc-macro2 = { version = "1.0.64" }
# quote = { version = "1.0.33" }
# rlp = { version = "0.5.2", default-features = false }
# sp-tracing = { version = "16.0.0", default-features = false }
# syn = { version = "2.0.53" }
# tempfile = { version = "3.8.1" }
# toml = { version = "0.8.8" }
# wat = { version = "1.0.0" }
2 changes: 1 addition & 1 deletion extension/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ mod extension {
// Invalid encoded runtime call.
let input = vec![0u8, 99];
let mut env = MockEnvironment::new(DispatchExtFuncId::get(), input.clone());
let mut extension = Extension::<mock::Config>::default();
let mut extension: Extension<mock::Config> = Extension::<mock::Config>::default();
assert!(extension.call(&mut env).is_err());
// Charges weight.
assert_eq!(
Expand Down
14 changes: 13 additions & 1 deletion pallets/api/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,26 @@ frame-benchmarking.workspace = true
frame-support.workspace = true
frame-system.workspace = true
pallet-assets.workspace = true
pallet-balances.workspace = true
pallet-timestamp.workspace = true
pallet-nfts.workspace = true
sp-core.workspace = true
sp-io.workspace = true
sp-runtime.workspace = true
sp-std.workspace = true
sp-weights.workspace = true

# Cross chain
ismp.workspace = true
pallet-ismp.workspace = true
Copy link
Collaborator

@evilrobot-01 evilrobot-01 May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only usage seems to be an implementation of IsmpModuleWeight. Could avoid by copying the trait and then creating an adapter type in the runtime to forward the calls. Commenting out the impl still compiles, unless I am missing a feature, so questionable whether its even required at all.

pallet-xcm.workspace = true
xcm.workspace = true
xcm-builder.workspace = true

[dev-dependencies]
pallet-balances.workspace = true
sp-io.workspace = true
pallet-ismp = { workspace = true, features = [ "unsigned" ] }
Copy link
Collaborator

@evilrobot-01 evilrobot-01 May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we werent using unsigned anymore?

xcm-builder.workspace = true

[features]
default = [ "std" ]
Expand All @@ -44,7 +51,10 @@ runtime-benchmarks = [
"frame-support/runtime-benchmarks",
"frame-system/runtime-benchmarks",
"pallet-assets/runtime-benchmarks",
"pallet-balances/runtime-benchmarks",
"pallet-nfts/runtime-benchmarks",
"pallet-timestamp/runtime-benchmarks",
"pallet-xcm/runtime-benchmarks",
"pop-chain-extension/runtime-benchmarks",
"sp-runtime/runtime-benchmarks",
]
Expand All @@ -58,12 +68,14 @@ std = [
"pallet-balances/std",
"pallet-ismp/std",
"pallet-nfts/std",
"pallet-xcm/std",
"pop-chain-extension/std",
"scale-info/std",
"sp-core/std",
"sp-io/std",
"sp-runtime/std",
"sp-std/std",
"xcm-builder/std"
]
try-runtime = [
"frame-support/try-runtime",
Expand Down
Loading