Support amd64 and aarch64 in one jar #93
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Scoured the JavaFX source and uploaded a new revision that puts the libraries in a temporary directory |
|
Agreed 👍 |
ausbin
added a commit
to gt-cs2110/CircuitSim
that referenced
this pull request
Sep 3, 2023
See ra4king#93 (cherry picked from commit 8c8a5e5) (cherry picked from commit a55de2f) (cherry picked from commit fe3ed3e)
ausbin
added a commit
to gt-cs2110/CircuitSim
that referenced
this pull request
Sep 3, 2023
See ra4king#93 (cherry picked from commit 8c8a5e5) (cherry picked from commit a55de2f) (cherry picked from commit fe3ed3e)
Contributor
Author
|
Tested with the following systems:
Merged this into the 2110 fork and released our own 1.9.2b release. Releasing it to students soon, we'll see how it goes! |
Contributor
Author
|
Pushed up a couple of tweaks we're deploying in the 2110 fork and autograders:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a long comment in the diff explaining how this works.
The main downside for this is that we write the native libraries to the same directory as the jar (especially considering running multiple copies of CircuitSim).
Hopefully we can use this as a starting point. Right now I don't like the idea of dumping a bunch of
.dylibs on a poor M1 student's desktop, even if it does make CircuitSim run without strange third-party java builds