Print the average each iteration when looping forever #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raas
reviewed
Jan 17, 2019
| { | ||
| char c[80]; | ||
| ++avg_count; | ||
| printf("AVG %d\t", avg_count); |
Owner
There was a problem hiding this comment.
why not suppress this too, if -a was specified?
(sorry for the super slow responses)
Otherwise it doesn't display an average at all. It is better to display it every loop because your eye can easily spot the average based on the one that doesn't change as much. Press return to reset the average, I find on one system killing and restarting can vary a lot, better to keep it running and reset the average when something else changed on the system.
Author
|
I wasn't aware of the option, fixed in commit 58234ac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it doesn't display an average at all. It is better to
display it every loop because your eye can easily spot the average
based on the one that doesn't change as much.
Press return to reset the average, I find on one system killing and
restarting can vary a lot (memory layout of what pages were chosen?),
better to keep it running and reset the average when something else
changed on the system. Unfortunately setting stdin to non-blocking has the
side effect that stdout is also non-blocking and so control-s discards
the print messages until control-q is pressed.
This updates the man page with 0 is forever and return resets the
average.