Skip to content

Remove unnecessary code to use other element. Not just DIV #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thiagonzalez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unnecessary code to use other element. Not just DIV #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions jquery.smint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,38 +30,38 @@ If you like Smint, or have suggestions on how it could be improved, send me a tw
var menuHeight = $(".smint").height();

return $('.smint a').each( function(index) {

if ( settings.scrollSpeed ) {
var scrollSpeed = settings.scrollSpeed
}

//Fill the menu
var id = $(this).attr("id");
optionLocs.push(Array($("div."+id).position().top-menuHeight, $("div."+id).height()+$("div."+id).position().top, id));
optionLocs.push(Array($("."+id).position().top-menuHeight, $("."+id).height()+$("."+id).position().top, id));

///////////////////////////////////

// get initial top offset for the menu
var stickyTop = $('.smint').offset().top;
// get initial top offset for the menu
var stickyTop = $('.smint').offset().top;

// check position and make sticky if needed
var stickyMenu = function(direction){

// current distance top
var scrollTop = $(window).scrollTop();
var scrollTop = $(window).scrollTop();

// if we scroll more than the navigation, change its position to fixed and add class 'fxd', otherwise change it back to absolute and remove the class
if (scrollTop > stickyTop) {
$('.smint').css({ 'position': 'fixed', 'top':0 }).addClass('fxd');
if (scrollTop > stickyTop) {
$('.smint').css({ 'position': 'fixed', 'top':0 }).addClass('fxd');
} else {
$('.smint').css({ 'position': 'absolute', 'top':stickyTop }).removeClass('fxd');
}
$('.smint').css({ 'position': 'absolute', 'top':stickyTop }).removeClass('fxd');
}

//Check if the position is inside then change the menu
// Courtesy of Ryan Clarke (@clarkieryan)


if(optionLocs[index][0] <= scrollTop && scrollTop <= optionLocs[index][1]){
if(optionLocs[index][0] <= scrollTop && scrollTop <= optionLocs[index][1]){
if(direction == "up"){
$("#"+id).addClass("active");
$("#"+optionLocs[index+1][2]).removeClass("active");
Expand Down Expand Up @@ -105,19 +105,19 @@ If you like Smint, or have suggestions on how it could be improved, send me a tw
});

///////////////////////////////////////


$(this).on('click', function(e){
// gets the height of the users div. This is used for off-setting the scroll so the menu doesnt overlap any content in the div they jst scrolled to
var selectorHeight = $('.smint').height();
var selectorHeight = $('.smint').height();

// stops empty hrefs making the page jump when clicked
e.preventDefault();

// get id pf the button you just clicked
var id = $(this).attr('id');

// if the link has the smint-disable class it will be ignored
// if the link has the smint-disable class it will be ignored
// Courtesy of mcpacosy ‏(@mcpacosy)

if ($(this).hasClass("smint-disable"))
Expand All @@ -126,12 +126,12 @@ If you like Smint, or have suggestions on how it could be improved, send me a tw
}

// gets the distance from top of the div class that matches your button id minus the height of the nav menu. This means the nav wont initially overlap the content.
var goTo = $('div.'+ id).offset().top -selectorHeight;
var goTo = $('.'+ id).offset().top -selectorHeight;

// Scroll the page to the desired position!
$("html, body").animate({ scrollTop: goTo }, scrollSpeed);

});
});
});
}

Expand Down