If checkbox is disabled, add disabled class#82
Open
phillc wants to merge 1 commit intoracehub:developfrom
Open
If checkbox is disabled, add disabled class#82phillc wants to merge 1 commit intoracehub:developfrom
phillc wants to merge 1 commit intoracehub:developfrom
Conversation
Contributor
Author
|
Any thoughts on this? |
Contributor
Author
|
ping |
|
fwiw we've been using this code in production for months |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a checkbox is disabled, the wrapping div needs the disabled class as well, so that the label can be styled correctly (change to the disabled cursor) http://getbootstrap.com/css/#checkboxes-and-radios
I'm not 100% sure if I did this correctly. According to the gist linked in the comments above t/separate, it says to just repass it in explicitly ( https://gist.github.com/sebmarkbage/a6e220b7097eb3c79ab7#consuming-and-transferring-the-same-prop ), and this was my interpretation of it... and I saw that a few places, like radio-options, do something similar.