Open
Conversation
Also adjusts Tox only check the sciunit source code and tests.
Member
|
Please update your commit messages to follow the conventions. Details here. |
…then it breaks the sqlite db. This was caused by the db using autoincrement so the eid in the db and the add functionality mismatched. (radiant-systems-lab#21)
sranasir
requested changes
Nov 23, 2025
Member
sranasir
left a comment
sranasir
left a comment
There was a problem hiding this comment.
Please remove the following file from your commit:
.idea/workspace.xml
Additionally, please update your commit messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Fixed sciunit rm issue where if the user removes the latest eid then it breaks the sqlite db.
This was caused by the db using autoincrement so the eid in the db and the add functionality mismatched.
(#21)