Fix memory leaks problems in t/local/44_sess.t reported by Assress Sanitizer #505 Fix t local sess #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adjust expected values of some tests, and far as when you call CTX_free, is automatically call remove_cb callback, and it changes expected call back call count values
…by increasing reference count. We should cancel that reservation by calling SSL_SESSION_free() anyway, not caring if session have been detached or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you build perl (and consequently Net::SSLleay) using Address Sanitizer,
t/local/44_sess.ttest will fail.This PR is made from two patches:
First patch: Adds
CTX_frees where they should be. But this affects testing results, as freeing a context trigger remove callback, as far as I guess. I've corrected expected results too.Second patch: Removes condition for SSL_SESSION_free() . We should always free session, without care if session remove was successful or not. See commit message for more explanations.
You can find instruction on how to build perl in this modulet using ASan in #469
PS please refer me as NATARAJ (Nikolay Shaplov) if you ever would like to mention me anywhere..