Implement checkbounds with no args + with kwargs#1183
Open
penelopeysm wants to merge 5 commits intorafaqz:mainfrom
Open
Implement checkbounds with no args + with kwargs#1183penelopeysm wants to merge 5 commits intorafaqz:mainfrom
checkbounds with no args + with kwargs#1183penelopeysm wants to merge 5 commits intorafaqz:mainfrom
Conversation
Contributor
Author
|
(Force-pushed to undo noisy changes from my overeager formatter) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
+ Coverage 86.96% 86.98% +0.01%
==========================================
Files 61 61
Lines 5848 5855 +7
==========================================
+ Hits 5086 5093 +7
Misses 762 762 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1156. Prior to this, any call to
checkboundswith either no arguments or with keyword arguments would error.On a pragmatic note, I'm not sure whether you would like PR submitters to bump the patch number + add a changelog note. Over on the Turing.jl ecosystem, we do that with every PR, so I'm very happy to do it here; let me know!