Skip to content

Conversation

@rajk1000
Copy link
Owner

No description provided.

Comment on lines +13 to +37
resource "aws_s3_bucket" "foo-bucket" {
region = var.region
bucket = local.bucket_name
force_destroy = true

tags = {
Name = "foo-${data.aws_caller_identity.current.account_id}"
}
versioning {
enabled = true
}
logging {
target_bucket = "${aws_s3_bucket.log_bucket.id}"
target_prefix = "log/"
}
server_side_encryption_configuration {
rule {
apply_server_side_encryption_by_default {
kms_master_key_id = "${aws_kms_key.mykey.arn}"
sse_algorithm = "aws:kms"
}
}
}
acl = "private"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tfsec check aws-s3-block-public-acls failed.

Description: No public access block so not blocking public acls

Severity: HIGH

For more information, see:

Comment on lines +13 to +37
resource "aws_s3_bucket" "foo-bucket" {
region = var.region
bucket = local.bucket_name
force_destroy = true

tags = {
Name = "foo-${data.aws_caller_identity.current.account_id}"
}
versioning {
enabled = true
}
logging {
target_bucket = "${aws_s3_bucket.log_bucket.id}"
target_prefix = "log/"
}
server_side_encryption_configuration {
rule {
apply_server_side_encryption_by_default {
kms_master_key_id = "${aws_kms_key.mykey.arn}"
sse_algorithm = "aws:kms"
}
}
}
acl = "private"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tfsec check aws-s3-block-public-policy failed.

Description: No public access block so not blocking public policies

Severity: HIGH

For more information, see:

Comment on lines +13 to +37
resource "aws_s3_bucket" "foo-bucket" {
region = var.region
bucket = local.bucket_name
force_destroy = true

tags = {
Name = "foo-${data.aws_caller_identity.current.account_id}"
}
versioning {
enabled = true
}
logging {
target_bucket = "${aws_s3_bucket.log_bucket.id}"
target_prefix = "log/"
}
server_side_encryption_configuration {
rule {
apply_server_side_encryption_by_default {
kms_master_key_id = "${aws_kms_key.mykey.arn}"
sse_algorithm = "aws:kms"
}
}
}
acl = "private"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tfsec check aws-s3-ignore-public-acls failed.

Description: No public access block so not ignoring public acls

Severity: HIGH

For more information, see:

Comment on lines +13 to +37
resource "aws_s3_bucket" "foo-bucket" {
region = var.region
bucket = local.bucket_name
force_destroy = true

tags = {
Name = "foo-${data.aws_caller_identity.current.account_id}"
}
versioning {
enabled = true
}
logging {
target_bucket = "${aws_s3_bucket.log_bucket.id}"
target_prefix = "log/"
}
server_side_encryption_configuration {
rule {
apply_server_side_encryption_by_default {
kms_master_key_id = "${aws_kms_key.mykey.arn}"
sse_algorithm = "aws:kms"
}
}
}
acl = "private"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tfsec check aws-s3-no-public-buckets failed.

Description: No public access block so not restricting public buckets

Severity: HIGH

For more information, see:

Comment on lines +13 to +37
resource "aws_s3_bucket" "foo-bucket" {
region = var.region
bucket = local.bucket_name
force_destroy = true

tags = {
Name = "foo-${data.aws_caller_identity.current.account_id}"
}
versioning {
enabled = true
}
logging {
target_bucket = "${aws_s3_bucket.log_bucket.id}"
target_prefix = "log/"
}
server_side_encryption_configuration {
rule {
apply_server_side_encryption_by_default {
kms_master_key_id = "${aws_kms_key.mykey.arn}"
sse_algorithm = "aws:kms"
}
}
}
acl = "private"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tfsec check aws-s3-specify-public-access-block failed.

Description: Bucket does not have a corresponding public access block.

Severity: LOW

For more information, see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants