Added the .elems method to XML::Element and XML::Document, and added …#72
Merged
lizmat merged 3 commits intoraku-community-modules:mainfrom Feb 21, 2025
Merged
Conversation
…some tests for the Positional role
Contributor
|
Thanks! I'm not sure, but shouldn't this also mean some additional documentation? |
Contributor
Author
|
Arguably. The documentation already says that it can and should be accessed like an array, which I thought was enough, but probably worth documenting because of the XML::Element vs. .elems confusion. I'll do that too. |
Contributor
Author
|
OK, documentation added! Thanks! |
Contributor
|
Thanks! Should I wait for your Associative work before doing a release? |
Contributor
Author
|
@lizmat I hope not; since we have tests, I'm in favour of "release early, release often" :) . |
Contributor
|
Release done, 0.3.6 now in the ecosystem. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…some tests for the Positional role