Draft
Conversation
The fact that both xmldecl and doctypedecl were optional and had the comment and pi tokens after them with a star, a failure to reach the end of the file to get the $ to match, will shuffle match attempts between the first and second line ... One first step in making the parser fail faster when encountering an invalid document.
Better from a performance standpoint because of less opportunities to backtrack, but also prevents comments from including their stopper and other stuff up until another comment or pi stopper is seen.
Contributor
|
@timo do you think this PR has a future? Or alternatively, could it just be merged as-is? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the grammar faster and also correcter.