Remove unnecessary workspace validation in extension#17
Merged
ram-nadella merged 1 commit intomainfrom Jun 30, 2025
Merged
Conversation
The workspaceRoot check was preventing the language server from starting when no workspace folder was open. This is overly restrictive since: - LSP servers can operate without a workspace (single file mode) - Workspace information is automatically passed via LSP initialization - The LSP spec allows for null workspace folders This change allows the extension to be more flexible and follow VSCode LSP best practices by letting the server handle workspace scenarios. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
The previous implementation was overly restrictive by refusing to start the language server when no workspace folder was present. This cleanup addresses several issues:
Important Discovery: Previous Bug
The removed code actually contained a bug that was never caught by tests:
testFixture), so they never encountered the early return scenarioThis change fixes that bug by allowing the extension to activate regardless of workspace presence.
Changes
workspaceRootvariable and validation logic fromextension.tsTest Results
npm test)npm run lint)npm run format)Note on Testing
Adding tests for the no-workspace scenario would require significant test infrastructure changes (running tests without providing a workspace path). Given that:
I've opted to keep the test suite as-is, but document this behavior improvement.
🤖 Generated with Claude Code