Remove redundant configurations and clean up extension#20
Merged
ram-nadella merged 1 commit intomainfrom Jun 30, 2025
Merged
Conversation
- Remove redundant file system watcher (pylight handles file watching internally) - Remove verbose LSP tracing by default, make it configurable via settings - Remove redundant Python language registration (VS Code provides this) - Make exclude patterns configurable with empty default (let users decide) - Clean up unused test utilities (doc, editor, documentEol, platformEol, setTestContent) These changes reduce overhead, improve configurability, and remove unnecessary code. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
File System Watcher
The extension was creating a VS Code file watcher for Python files, but this is redundant since pylight already implements its own file watching. This eliminates:
Configuration Changes
Added two new settings:
pydance.trace.server: Control LSP trace verbosity (off/messages/verbose)pydance.excludePatterns: User-configurable exclude patterns (empty by default)Code Cleanup
Test Plan
npm run format:check && npm run lint)npm test)🤖 Generated with Claude Code