Skip to content

Conversation

@tinodin
Copy link
Contributor

@tinodin tinodin commented May 18, 2025

Automatically changes between light and dark mode based on a set schedule.

@m417z
Copy link
Member

m417z commented May 18, 2025

This mod is injected into explorer and runs as part of it. This is suboptimal for the following reasons:

  • There can be more than one explorer.exe process in case the "launch folder windows in separate process" option is enabled, and for other reasons.
  • This mod doesn't have a good reason to be injected into explorer.exe, it's just convenient. But by doing so, a mistake or instability in the mod affects the whole shell.

This is not the first mod to take this approach. Here are other recent mods:

And maybe also:

All three mods could be separate tools, they don't use and don't need Windhawk's injection and hooking capabilities. On the other hand, I can understand that the ease of mod installation is appealing. I wonder if Windhawk needs to come up with a new type of mods which run as part of a dedicated process.

@tinodin tinodin closed this by deleting the head repository May 18, 2025
@m417z
Copy link
Member

m417z commented May 18, 2025

Just to be clear, I didn't mean to say that the mod won't be accepted. I was just thinking out loud about the problems with the current approach. Still, I think that such mods can be valuable. Since there's no mechanism in Windhawk right now for such tool-like mods, perhaps some temporary solution can be implemented in the mod itself. I'll give it some thought. Meanwhile, feel free to reopen the PR and we'll keep discussing it.

@tinodin
Copy link
Contributor Author

tinodin commented May 19, 2025

Yes sorry, I know I just deleted the fork as I accidentally added another mod to it. If you want I can create a new pull request as I can not reopen this one.

@m417z
Copy link
Member

m417z commented May 19, 2025

Go ahead and create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants