-
Notifications
You must be signed in to change notification settings - Fork 166
Add Mod: Windows 11 Better Ultrawide Taskbar #2803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the submission. Here's how it looks on my computer with the default settings, I assume the edges shouldn't look like this:
Also, you're using XAML Diagnostics ( You can keep it as is, in which case I think it'd be a good idea to add a notice about it in the readme. Alternatively, you might want to update the implementation such that XAML Diagnostics API isn't used. There are several mod examples which can serve as an example, for example Start button always on the left: windhawk-mods/mods/taskbar-start-button-position.wh.cpp Lines 390 to 407 in 862ba36
|
|
thank you, yea I'll take a look at other examples. I want to minimize the conflict with other mods, but I'm pretty new to the modding here, do you mind helping me understand some other potential conflicts or preferred method that I should look into? |
|
XAML Diagnostics API is a unique conflict, as only one consumer can use it due to the way it works. The API was designed for debugging, and has several shortcomings. No other conflicts are expected unless you do something specific.
A good starting point is to take a mod which uses I provided |
|
Updated to use |
| { | ||
| try | ||
| { | ||
| taskbarFrame.LayoutUpdated(g_layoutUpdatedToken); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be run from the taskbar (UI) thread.
Something like:
HWND hTaskbarWnd = FindCurrentProcessTaskbarWnd();
if (hTaskbarWnd)
{
RunFromWindowThread(
hTaskbarWnd, [](void *pParam)
{ /* cleanup code here */ }, 0);
}Also generally, I suggest to at least print errors instead of having empty catch blocks.

Add a mod to center taskbar and system tray as a single unit to provide better usability in ultrawide screen.
Also offer an offset only mode to just offset the system tray.