Skip to content

Deleting unwanted manual setup instructions #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deleting unwanted manual setup instructions #3984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions .../en/k8s-in-rancher/horitzontal-pod-autoscaler/manage-hpa-with-kubectl/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,26 +124,9 @@ For this example, we are going to use [Prometheus](https://prometheus.io/). We a

Prometheus is available for deployment in the Rancher v2.0 catalog. Deploy it from Rancher catalog if it isn't already running in your cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should refer to the installation of the rancher-monitoring chart instead and link to the Monitoring docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axeal , while I'm happy to make the changes I think it would be good creating another section for the rancher-monitoring chart because this section is explicitly detailing using third-party tools such as Prometheus.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axeal : Gentle reminder on the above, please could you let me know your response?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divya-mohan0209 This section (https://github.com/rancher/docs/blob/b4f4bfb8cdcfd38bbaad86e1838d00a8933dd52f/content/rancher/v2.x/en/k8s-in-rancher/horitzontal-pod-autoscaler/_index.md) pre-dates the Rancher v2.2 release (https://github.com/rancher/rancher/releases/v2.2.0) that introduced monitoring as a feature into Rancher v2. With monitoring, including prometheus and prometheus-adapter, available as a feature out-of-the-box, documentation on installing a custom prometheus adapter instance for a custom Prometheus deployment do not seem relevant anymore.


For HPA to use custom metrics from Prometheus, package [k8s-prometheus-adapter](https://github.com/DirectXMan12/k8s-prometheus-adapter) is required in the `kube-system` namespace of your cluster. To install `k8s-prometheus-adapter`, we are using the Helm chart available at [banzai-charts](https://github.com/banzaicloud/banzai-charts).

1. Initialize Helm in your cluster.
```
# kubectl -n kube-system create serviceaccount tiller
kubectl create clusterrolebinding tiller --clusterrole cluster-admin --serviceaccount=kube-system:tiller
helm init --service-account tiller
```

1. Clone the `banzai-charts` repo from GitHub:
```
# git clone https://github.com/banzaicloud/banzai-charts
```

1. Install the `prometheus-adapter` chart, specifying the Prometheus URL and port number.
```
# helm install --name prometheus-adapter banzai-charts/prometheus-adapter --set prometheus.url="http://prometheus.mycompany.io",prometheus.port="80" --namespace kube-system
```

1. Check that `prometheus-adapter` is running properly. Check the service pod and logs in the `kube-system` namespace.
For HPA to use custom metrics from Prometheus, package [k8s-prometheus-adapter](https://github.com/DirectXMan12/k8s-prometheus-adapter) is required in the `kube-system` namespace of your cluster. As of v2.5, the `prometheus-adapter` is installed out-of-the box and does not require manual setup.

1. Verify if `prometheus-adapter` is running properly. Check the service pod and logs in the `kube-system` namespace.

1. Check that the service pod is `Running`. Enter the following command.
```
Expand Down
23 changes: 3 additions & 20 deletions .../en/k8s-in-rancher/horitzontal-pod-autoscaler/manage-hpa-with-kubectl/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,26 +121,9 @@ For this example, we are going to use [Prometheus](https://prometheus.io/). We a

Prometheus is available for deployment in the Rancher v2.0 catalog. Deploy it from Rancher catalog if it isn't already running in your cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above for v2.5: "I think we should refer to the installation of the rancher-monitoring chart instead and link to the Monitoring docs."


For HPA to use custom metrics from Prometheus, package [k8s-prometheus-adapter](https://github.com/DirectXMan12/k8s-prometheus-adapter) is required in the `kube-system` namespace of your cluster. To install `k8s-prometheus-adapter`, we are using the Helm chart available at [banzai-charts](https://github.com/banzaicloud/banzai-charts).

1. Initialize Helm in your cluster.
```
# kubectl -n kube-system create serviceaccount tiller
kubectl create clusterrolebinding tiller --clusterrole cluster-admin --serviceaccount=kube-system:tiller
helm init --service-account tiller
```

1. Clone the `banzai-charts` repo from GitHub:
```
# git clone https://github.com/banzaicloud/banzai-charts
```

1. Install the `prometheus-adapter` chart, specifying the Prometheus URL and port number.
```
# helm install --name prometheus-adapter banzai-charts/prometheus-adapter --set prometheus.url="http://prometheus.mycompany.io",prometheus.port="80" --namespace kube-system
```

1. Check that `prometheus-adapter` is running properly. Check the service pod and logs in the `kube-system` namespace.
For HPA to use custom metrics from Prometheus, package [k8s-prometheus-adapter](https://github.com/DirectXMan12/k8s-prometheus-adapter) is required in the `kube-system` namespace of your cluster. For HPA to use custom metrics from Prometheus, package [k8s-prometheus-adapter](https://github.com/DirectXMan12/k8s-prometheus-adapter) is required in the `kube-system` namespace of your cluster. As of v2.5, the `prometheus-adapter` is installed out-of-the box and does not require manual setup.

1. Verify if `prometheus-adapter` is running properly. Check the service pod and logs in the `kube-system` namespace.

1. Check that the service pod is `Running`. Enter the following command.
```
Expand Down