Expose a method to remove a stale reference for subclasses that overr…#12
Open
anuraaga wants to merge 3 commits intoraphw:masterfrom
Open
Expose a method to remove a stale reference for subclasses that overr…#12anuraaga wants to merge 3 commits intoraphw:masterfrom
anuraaga wants to merge 3 commits intoraphw:masterfrom
Conversation
added 3 commits
November 24, 2020 16:21
This was referenced Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ide expungeStaleEntries.
As far as I can tell, there isn't a proper way of a subclass extending and overriding
expungeStaleEntriessince there's no way to actually remove the reference from the map, so it's a guaranteed memory leak. This exposes the removal for subclasses./cc @adriancole