Fix pinned memory resource shared_pointer lifetime in tests.
#20407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
changed the title
davidwendt
approved these changes
Oct 28, 2025
vuule
approved these changes
Oct 28, 2025
Member
|
@bdice have you figured out the fix for the similar issue in UTILITY_TEST? |
Contributor
Author
Yes, that should be handled by rapidsai/rmm#2107. Or at least, that test didn’t fail locally once the RMM changes were applied. |
PointKernel
approved these changes
Oct 28, 2025
Contributor
Author
|
/merge |
bdice
changed the title
shared_pointer lifetime in tests.
Contributor
Author
|
Ack. Something was different in my local testing, I need a similar fix in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a shared_pointer whose lifetime isn't being properly managed. This fixes it.
Checklist