feat: support actual depth image with 32FC1 datatype#349
feat: support actual depth image with 32FC1 datatype#349yuokamoto merged 1 commit intorapyuta-robotics:develfrom bresilla:devel
Conversation
- Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability.
|
Some context: This PR updates the camera component to output depth data in 32FC1, a commonly used format for depth images. In this format, depth values are stored as 32-bit floating-point numbers, representing the distance (in meters) from the camera. Previously, the implementation was incorrect because the depth image was stored in RGB8 format. In this format, the pixel values—particularly the R channel, which typically holds depth data in Unreal—did not accurately represent depth. Instead, they were just a visual representation rather than meaningful depth values. |
|
Thank you very much! Thanks in advance. |
|
@yuokamoto |
|
Any update on this?? I am working to add camera segmentation based on Unreal Stencil thingy. Would be cool if this gets reviewed before. |
|
@yuokamoto depth_test.mp4 |
Cool thankyou! |
…s#349) - Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability.
- Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability. Co-authored-by: Trim Bresilla <trim.bresilla@gmail.com>
- Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability.
- Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability. Co-authored-by: Trim Bresilla <trim.bresilla@gmail.com>
- Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability.
* feat: support actual depth image with 32FC1 datatype (#349) - Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability. * update action --------- Co-authored-by: Trim Bresilla <trim.bresilla@gmail.com>
* feat: support actual depth image with 32FC1 datatype (#349) - Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability. * update action --------- Co-authored-by: Trim Bresilla <trim.bresilla@gmail.com>
* feat: support actual depth image with 32FC1 datatype (#349) - Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability. * update action --------- Co-authored-by: Trim Bresilla <trim.bresilla@gmail.com>
* feat: support actual depth image with 32FC1 datatype (#349) - Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability. * update action --------- Co-authored-by: Trim Bresilla <trim.bresilla@gmail.com>
* feat: support actual depth image with 32FC1 datatype (#349) - Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability. * update action --------- Co-authored-by: Trim Bresilla <trim.bresilla@gmail.com>
* feat: support actual depth image with 32FC1 datatype (#349) - Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability. * update action --------- Co-authored-by: yuokamoto <yuokamoto1988@gmail.com> Co-authored-by: Trim Bresilla <trim.bresilla@gmail.com>
* feat: support actual depth image with 32FC1 datatype (#349) - Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability. * update action --------- Co-authored-by: yuokamoto <yuokamoto1988@gmail.com> Co-authored-by: Trim Bresilla <trim.bresilla@gmail.com>
* feat: support actual depth image with 32FC1 datatype (#349) - Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability. * update action --------- Co-authored-by: yuokamoto <yuokamoto1988@gmail.com> Co-authored-by: Trim Bresilla <trim.bresilla@gmail.com>
* feat: support actual depth image with 32FC1 datatype (#349) - Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability. * update action --------- Co-authored-by: yuokamoto <yuokamoto1988@gmail.com> Co-authored-by: Trim Bresilla <trim.bresilla@gmail.com>
* feat: support actual depth image with 32FC1 datatype (#349) - Add separate processing for RGB and Depth camera types with specific capture source and image properties. - Introduce new data structures to handle RGB and Depth surface contexts. - Adjust pixel format and data handling based on camera type, including custom encoding and image data initialization. - Improve conditions for processing captured data by ensuring proper checks are in place for RGB and Depth data retrieval. - Add a `Depth` array to `FRenderRequest` struct to store depth information. - Remove obsolete comments and redundant code sections to improve readability and maintainability. * update action --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: yuokamoto <yuokamoto1988@gmail.com> Co-authored-by: Trim Bresilla <trim.bresilla@gmail.com>
Deptharray toFRenderRequeststruct to store depth information.