Skip to content

feat: harden qrcode flow, CI, and logo customization#12

Merged
raskitoma merged 2 commits intomasterfrom
fix/qrcode-hardening
Mar 9, 2026
Merged

feat: harden qrcode flow, CI, and logo customization#12
raskitoma merged 2 commits intomasterfrom
fix/qrcode-hardening

Conversation

@raskitoma
Copy link
Owner

@raskitoma raskitoma commented Mar 9, 2026

Summary\n- remove Sonar token-bearing README badge reference\n- add QR input validation and basic tests\n- pin Docker base image to Python 3.12 Alpine\n- modernize CI to run unit tests on push/PR before Sonar analysis\n- add empty-state placeholder UI when no text is entered\n- add optional logo upload with adjustable size and centered rendering\n\n## Validation\n- foxhound Docker Compose review instance tested successfully\n- homepage returns 200\n- QR generation returns PNG\n- blank input is rejected with 400\n- placeholder and logo customization behavior verified in review deployment\n

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 635f6a6e4e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +39 to 43
- name: SonarQube scan
uses: SonarSource/sonarqube-scan-action@v6
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Guard Sonar scan against forked pull_request runs

This step now runs on every pull_request, but forked PRs do not receive repository secrets, so SONAR_TOKEN/SONAR_HOST_URL are empty in that context and the Sonar action fails; that makes the workflow fail for external contributors even when tests pass. This regression was introduced by adding the pull_request trigger without gating the Sonar step, so the scan should be conditional (or moved to a trusted event) for forked PRs.

Useful? React with 👍 / 👎.

@raskitoma raskitoma changed the title fix: harden qrcode input handling and CI feat: harden qrcode flow, CI, and logo customization Mar 9, 2026
@raskitoma raskitoma merged commit 9f6ba33 into master Mar 9, 2026
1 check failed
@raskitoma raskitoma deleted the fix/qrcode-hardening branch March 9, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant