Enable hard-float ABI support for pico_float and pico_double for m33 #2785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable support for
-mfloat-abi=hardinpico_float:vfpandpico_double:pico-dcp.Exclude
pico_float:dcp, since this variant is intended for non-FPU configurations.Toolchain:
arm-gnu-toolchain-14.3.rel1Implementation:
__aeabi_*runtime helper functions (__aeabi_x2y) have more direct path than custom functions (xtoy).Test:
__aeabi_*functions should be explicitly marked as__attribute__((pcs("aapcs")))when the hard abi is enabled.Resolves #2783, resolves #1993 (maybe duplicated)
BTW, it seems like
src/rp2_common/pico_double/double_fma_dcp.Sis not covered by any test case yet.