Check correctly for protocols that handle their own files #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some protocols open their own file handes, so we mustn't try to do this for them as it will fail. The correct way to do this is to check the context's oformat->flags, not the flags field directly. The reason is that the flags report the current state of the context, whereas oformat->flags reports what this particular output format requires, which is therefore correct. The consequence is that we can output RTSP streams directly, which is useful for publishing to media servers like MediaMTX using a runOnDemand command. Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
naushir
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some protocols open their own file handes, so we mustn't try to do this for them as it will fail. The correct way to do this is to check the context's oformat->flags, not the flags field directly.
The reason is that the flags report the current state of the context, whereas oformat->flags reports what this particular output format requires, which is therefore correct.
The consequence is that we can output RTSP streams directly, which is useful for publishing to media servers like MediaMTX using a runOnDemand command.