PanelMenu Button for compatibility and for using Menus when needed #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace StBoxLayout with a standard Top Panel PanelMenu.Button and its container. This allows compatibility with other extensions like Open Bar and with custom user themes. Also, takes steps towards building a Menu as discussed in an issue.
Owner
|
Thanks for your work, I appreciate it. Just wanted to let you know that I will look at the changes eventually, I have not forgotten it. Thanks for your patience! |
The panel button is updated to have a menu. The menu opens on left click as is the default behavior for all panel menus. It currently contains only one item for "Settings" which upon click opens settings page as before.
Author
|
Thank you for the update. I have added another commit for the menu. So now, clicking on executor buttons opens a menu with one item in it for the Settings. More items can be added as needed. You can try it out as per your convenience, leaving it here for whenever you are ready. |
- The indicator needed to be destroyed in disable(). - Also, the GLib timeout Ids are stored in an array and remain there even after they expire. Thus, when disabling, it complains that the timeout Ids are not found on GLib Remove. They need to be null'ed out when the timeout expires and in disable we check if the timeout Id still exists and only then remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR replaces
St.BoxLayoutwith a standard Gnome Top PanelPanelMenu.Buttonand its container Bin. This allows compatibility with other extensions like Open Bar and with custom user themes expecting standard buttons layout.Also, it takes steps towards building a Menu as discussed in this issue. I have currently created PanelMenu Button with a DummyMenu set to true (meaning no menu exists) which can be set to false when needed and Menu items can be added.
Cheers.