fix: handle dual task errors with read-only args #59507
Conversation
ray: handle dual task errors with read-only args - avoid writing to user-defined args when building RayTaskError hybrids - fall back to RayTaskError-only with warning if subclassing fails - add regression test covering read-only args user exceptions
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors how RayTaskError handles the args attribute of wrapped user exceptions. Previously, RayTaskError directly assigned to self.args, which could cause issues if the user's custom exception defined args as a read-only property. The changes introduce a private attribute _ray_task_error_args and implement args as a property with a setter, allowing RayTaskError to manage its own arguments without conflicting with potentially read-only user-defined args. Additionally, a new exception handler was added to as_instanceof_cause to log warnings when subclassing fails due to user exceptions overriding attributes like args. A new test case was added to verify that RayTaskError correctly wraps and propagates exceptions that have read-only args properties.
ray-gardener
bot
added
core
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
Overall LGTM. Just a small suggestion for more thorough testing.
[core][test] Added both assertions to test_task_error_with_read_only_args_property assert isinstance(exc_info.value, ReadOnlyArgsError) to confirm dual inheritance assert exc_info.value.args == (exc_info.value.cause,) to confirm the args shim works
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
github-actions
bot
added
the
stale
github-actions
bot
added
unstale
3 participants
Description
ray: handle dual task errors with read-only args
Related issues
Fixes #59437