Fix bug that caused existing pastes to be overwritten after restart#7
Open
jonjensen wants to merge 1 commit intorcaputo:masterfrom
Open
Fix bug that caused existing pastes to be overwritten after restart#7jonjensen wants to merge 1 commit intorcaputo:masterfrom
jonjensen wants to merge 1 commit intorcaputo:masterfrom
Conversation
The existing paste IDs were being sorted as strings, not numbers, so the "highest" one was often not really the highest one, and the when the next assigned ID already existed, that paste was silently overwritten.
|
@rcaputo this simple patch looks like it fixes an important bug. Any feedback, or willing to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing paste IDs were being sorted as strings, not numbers,
so the "highest" one was often not really the highest one, and the
when the next assigned ID already existed, that paste was silently
overwritten.