Skip to content

Conversation

@joyliu37
Copy link
Collaborator

I made some changes to the verilog analysis passes and it work for me for the issue.
#941

@joyliu37 joyliu37 requested review from leonardt and rdaly525 June 25, 2021 18:54
@leonardt
Copy link
Collaborator

It seems like this is the code we should be trying to use: https://github.com/rdaly525/coreir/pull/1013/files#diff-1d13ccebd6fd308ba92fd6d7889462cc6b4a370afdbc5edb561dfe2ddab84781R1147-R1154 but because they metadata is lost when you save to JSON it's not working. Let me investigate the options there, perhaps we should save that metadata to be persistent across invocations. However, it's likely that you should also just be able to save the verilog file directly from the runtime which would avoid that issue.

@rdaly525
Copy link
Owner

@joyliu37 if you use serializeToFile(...) instead of saveToFile(...) All the metadata and dependencies will get saved in the one verilog file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants