feat(tui): extend interactive UI for multi-pipeline sequence selection and DAG preview#219
Open
nextlevelshit wants to merge 4 commits intomainfrom
Open
feat(tui): extend interactive UI for multi-pipeline sequence selection and DAG preview#219nextlevelshit wants to merge 4 commits intomainfrom
nextlevelshit wants to merge 4 commits intomainfrom
Conversation
Add tiered execution support to MatrixStrategy, enabling items with dependencies to execute in topologically-sorted tiers. Items within a tier run in parallel; tiers execute sequentially. New MatrixStrategy fields: - item_id_key: dot-path to unique ID field in each item - dependency_key: dot-path to dependency array in each item - child_pipeline: name of pipeline to invoke per item (Phase 2) - input_template: Go template for constructing input (Phase 2) New MatrixResult fields: Skipped, SkipReason, ItemID Implementation uses Kahn's algorithm (BFS topological sort) to compute tiers. Dependency failure propagation skips downstream items but allows unrelated items to continue. 6 new tests covering independent items, linear chains, diamond dependencies, dependency failure propagation, cycle detection, and missing dependency validation.
Add the ability for matrix strategy steps to invoke a full child pipeline per matrix item instead of executing a single step. This enables the gh-implement-epic pipeline to fan out gh-implement runs per subissue. Key additions: - NewChildExecutor() factory on DefaultPipelineExecutor for independent state - ChildPipeline field on MatrixStrategy to name or path a child pipeline - InputTemplate field with Go text/template rendering for item → input - Refactored tieredExecution to accept a matrixWorkerFunc for reuse - 5 new tests: LoadsAndExecutes, InputTemplate, WithTiers, PartialFailure, NotFound
New pipeline that consumes gh-scope output and implements all subissues by fanning out parallel gh-implement child pipeline runs, respecting the dependency ordering from the scope plan. Pipeline steps: - fetch-scope: parse epic's scope comment, extract subissues + deps - implement-subissues: matrix strategy with child_pipeline + dependency tiers - report: post implementation summary comment on parent epic Includes: - Pipeline YAML with matrix strategy using child_pipeline and dependency_key - Prompt files for fetch-scope and report steps - Contract schemas for epic-scope-plan and epic-report - Mock adapter output for testing (gh-implement-epic routing before gh-implement)
…n and DAG preview Add multi-pipeline proposal TUI with accept/modify/skip flow, text-based DAG preview, and parallel group visualization. Wire into CLI via --propose flag. New files: - internal/tui/proposal.go — Proposal, ProposalDecision, ProposalResult types with validation (empty name, circular dependency detection) - internal/tui/dag_preview.go — Text-based DAG renderer using Kahn's algorithm with box-drawing connectors, parallel group labels, terminal-width-aware label truncation - internal/tui/proposal_selector.go — RunProposalSelector entry point with per-proposal accept/modify/skip, parallel group multi-select, inline DAG preview, and confirmation - internal/tui/mock_proposals.go — MockProposalProvider for development/testing Modified files: - cmd/wave/commands/run.go — Added --propose flag dispatching to RunProposalSelector when interactive with mock proposals (gated on #208) Closes #209
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #209
Changes
TUI Extensions (
internal/tui/)proposal_selector.go— Multi-pipeline proposal selector with accept/modify/skip per proposal, multi-select support, and parallel group visualizationdag_preview.go— Text-based DAG preview renderer showing execution tiers, dependencies, and parallel-eligible groupingsproposal.go— Proposal data types and conversion logic between pipeline proposals and TUI display modelsmock_proposals.go— Test fixtures for proposal-based TUI testing*_test.go— Table-driven tests for DAG preview rendering, proposal selector behavior, and edge casesPipeline Executor (
internal/pipeline/)matrix.go— Extended matrix executor with dependency tier computation and child pipeline invocation supportmatrix_test.go— Comprehensive tests for tier resolution, cycle detection, and parallel groupingexecutor.go/types.go— Minor extensions to support matrix execution hooksEpic Pipeline (
.wave/)pipelines/gh-implement-epic.yaml— New multi-step epic implementation pipelinecontracts/epic-report.schema.json/epic-scope-plan.schema.json— JSON schemas for epic pipeline artifactsprompts/gh-implement-epic/— Persona prompts for epic fetch-scope and report stepsCLI (
cmd/wave/commands/)run.go— Proposal mode integration in the run commandrun_proposal_test.go— Tests for proposal flow entry pointSpecs (
specs/209-tui-multi-pipeline/)spec.md/plan.md/tasks.md— Feature specification, implementation plan, and task trackingTest Plan
go test ./...