feat(cli): support --model flag to override adapter model per run#232
Open
nextlevelshit wants to merge 1 commit intomainfrom
Open
feat(cli): support --model flag to override adapter model per run#232nextlevelshit wants to merge 1 commit intomainfrom
nextlevelshit wants to merge 1 commit intomainfrom
Conversation
7 tasks
Add a --model CLI flag to wave run, wave do, and wave meta that overrides the adapter model for a single invocation. The override is threaded through a new WithModelOverride executor option and applied in runStepExecution with three-tier precedence: per-persona model pinning > CLI --model flag > adapter default. Closes #198
46d9d75 to
a282ee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--modelflag towave run,wave do, andwave metacommandsruntime.adapter.modelfromwave.yamlfor a single invocationRunOptions→ executor → adapter cleanlyCloses #198
Changes
cmd/wave/commands/run.go— Added--modelpersistent flag to theruncommand, threaded intoRunOptionscmd/wave/commands/do.go— Added--modelpersistent flag to thedocommandcmd/wave/commands/meta.go— Added--modelpersistent flag to themetacommandinternal/pipeline/executor.go— ExtendedRunOptionswithModelOverridefield; executor applies override to adapter options when persona doesn't pin a modelinternal/pipeline/executor_test.go— Added comprehensive tests for override logic, per-persona precedence, and empty-override passthroughcmd/wave/commands/run_test.go,do_test.go,meta_test.go— Added flag registration testsspecs/198-model-flag-override/— Added specification, plan, and task artifactsTest Plan
go test ./...)