Skip to content

fix: prevent error when nativeElement is not available #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afc163 merged 3 commits into from
Dec 15, 2025
Merged

fix: prevent error when nativeElement is not available #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3bd49d
fix: prevent error when nativeElement is not available
cncolder Dec 15, 2025
1ef532e
Update src/Dialog/Content/index.tsx
cncolder Dec 15, 2025
3dad7dc
test: add check to prevent error when nativeElement is not available
cncolder Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Dialog/Content/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ const Content = React.forwardRef<ContentRef, ContentProps>((props, ref) => {
}

function onPrepare() {
if (!dialogRef.current?.nativeElement) {
return;
}

const elementOffset = offset(dialogRef.current.nativeElement);

setTransformOrigin(
Expand Down
12 changes: 12 additions & 0 deletions tests/index.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,18 @@ describe('dialog', () => {
document.querySelector<HTMLElement>('.rc-dialog').style['transform-origin'],
).toBeTruthy();
});

it('should not throw error when nativeElement is not available', () => {
expect(() => {
global.onAppearPrepare?.();
}).not.toThrow();

render(<Dialog visible />);

expect(() => {
global.onAppearPrepare?.();
}).not.toThrow();
});
});

it('can get dom element before dialog first show when forceRender is set true ', () => {
Expand Down
Loading