Add a prop to configure whether <kbd>esc</kbd> should close the panel
#106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a prop to configure whether `<kbd>esc</kbd>` should close the panel
|
I think this would be useful, I am facing a problem is that when I click on the selector it closes both the selector modal and the other modal I have open. Until this gets merged doo you know any workaround for this @cyrilfretlink ? |
|
It may be possible to toggle some state in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is useful when you have multiple components listening to esc and you don’t want to close them all at the same time (e.g. if you render this component inside a modal or a side panel).