- 
                Notifications
    You must be signed in to change notification settings 
- Fork 478
Async Storage v3 #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            krizzu
  wants to merge
  124
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
v3
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            Async Storage v3 #1215
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    because osx is using symlinks for versioning, distributing its framework via npm won't work - compression via tar breaks the link. therefore this script resolves the symlinks into actual folders, to match expected structure by macos.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Async Storage v3
Intro
I’ve been maintaining AsyncStorage for a while, and the growing issues have become a real burden. As I see it, the problems fall into a few categories:
All of this makes AsyncStorage harder to evolve and less reliable than it should be. My goal is to improve this library in terms of usage and maintenance.
Goals
Todo / Progress
Current progress of v3
General
Repo
default-storagepackage back to async-storage.sqlite-storageandapipackages. API was just a single interface, so it was moved toasync-storage.shared-storageas its only module. This is a Kotlin Multiplatform library for accessing the database.JavaScript API
getMany,setMany,removeMany).multiGet,multiSet, andmultiRemoverenamed to getMany, setMany, and removeMany. Their API also changed from array-based ([key, value]) to object-based ({ [key]: value }).mergeItemandmultiMergeremoved due to differences in implementation across platforms. The merging logic is best decided by the end user.createStoragemethod, where a database name must be provided.AsyncStorageErrorerror is thrown from AsyncStorage methods.Native
Android
iOS / macOS
Windows
Web
idbpackage).Documentation
async-storage/databasesdirectory$platform_db_directory/async-storage/databases/$databaseName/directory, where$databaseName.sqlitefiles areMigration from v2
Test plan
Each scenario tests for v3 functionality and v2 -> v3 migration (if data is retained on upgrade)
Backward compatibility with old architecture is also test
React Native CLI
Out of tree platforms
Expo
⠀