Skip to content

兼容 RN0.47 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
F-happy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

兼容 RN0.47 #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/src/main/java/com/reactnativecomponent/amap/RCTAMapPackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactConte
);
}

@Override
// 兼容 react-native 0.47
public List<Class<? extends JavaScriptModule>> createJSModules() {
Copy link

@qiuxiang qiuxiang Aug 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createJSModules 应该删掉，留着没有任何意义

return Collections.emptyList();
}
Expand Down