Skip to content

RN 0.47 android createJSModules deprecation fix #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tayfunyugruk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RN 0.47 android createJSModules deprecation fix #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
054a84b
RN 0.47 fix
tayfunyugruk Sep 5, 2017
db0786a
propType fix
tayfunyugruk Mar 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Barcode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@


import React, {
PropTypes,

Component,
} from 'react'
import {
Expand All @@ -16,7 +16,9 @@ import {
NativeModules,
AppState,
Platform,
ViewPropTypes
} from 'react-native'
import PropTypes from 'prop-types'

const BarcodeManager = Platform.OS == 'ios' ? NativeModules.Barcode : NativeModules.CaptureModule

Expand All @@ -34,7 +36,7 @@ export default class Barcode extends Component {
}

static propTypes = {
...View.propTypes,
...ViewPropTypes,
onBarCodeRead: PropTypes.func.isRequired,
barCodeTypes: PropTypes.array,
scannerRectWidth: PropTypes.number,
Expand Down Expand Up @@ -78,4 +80,4 @@ export default class Barcode extends Component {
}
}

const NativeBarCode = requireNativeComponent(Platform.OS == 'ios' ? 'RCTBarcode' : 'CaptureView', Barcode)
const NativeBarCode = requireNativeComponent(Platform.OS == 'ios' ? 'RCTBarcode' : 'CaptureView', Barcode)
5 changes: 0 additions & 5 deletions android/src/main/java/com/reactnativecomponent/barcode/RCTCapturePackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactAppli
);
}

@Override
public List<Class<? extends JavaScriptModule>> createJSModules() {
return Collections.emptyList();
}

@Override
public List<ViewManager> createViewManagers(ReactApplicationContext reactApplicationContext) {
//noinspection ArraysAsListWithZeroOrOneArgument
Expand Down