Skip to content

Conversation

@cbialorucki
Copy link
Contributor

@cbialorucki cbialorucki commented Oct 25, 2025

TODO

  • Discuss: should we add pictures?

@reactos-buildbot
Copy link
Collaborator

Thanks for your contribution!
I have built and deployed your changes to https://pr136.web-content.reactos.org and will also do that for your future changes.

Test results shown in Testman are also sometimes incorrect, especially when a test spawns child processes.
I plan to fix these issues with Testman during my contract.

Eventually I would like to see our test bots become part of our CI/CD pipeline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh.. they used to be 🙃 that reminds me to look at that colin mention.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC it will show tests, but only when launched manually. Also it would always be green, so it's not really useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted the wording of this to say that I want the test bots to become more important in our CI/CD checks rather than it being in our CI/CD checks at all.

@tkreuzer
Copy link

Regarding pictures: one thing I can think of is a comparison on Windows test results (the header with number of tests / failed tests) before and after your work. But that might be problematic because of the test bot rework and switch to x64 Vista. Anyway, if that looks good, you can include it :)

Copy link
Member

@learn-more learn-more left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be an option to create a graph of the test fail/pass of the before and after?
(If that is not too much work!)

title: "Progress update: fixing the ReactOS test suite"
author: "Carl Bialorucki"
date: 2025-11-04
tags: [ "newsletter", "tests", "test-suite" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to include a cover image, otherwise our homepage starts to look like a 404 page.

Image

@cbialorucki
Copy link
Contributor Author

cbialorucki commented Oct 27, 2025

Maybe it would be an option to create a graph of the test fail/pass of the before and after? (If that is not too much work!)

I can whip something together in Excel. Direct Testman results may be hard since the search interface is so broken.

@tkreuzer
Copy link

I can whip something together in Excel. Direct Testman results may be hard since the search interface is so broken.

Here's 2 comparisons:

Hard to compare due to changes to the runtime environment (new testbots, switch from x64 sk3 to vista)

Copy link
Contributor

@Doug-Lyons Doug-Lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a small graphic on the main website where this is mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants