-
Notifications
You must be signed in to change notification settings - Fork 46
Test suite progress update blog post #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your contribution! |
content/blogs/cbialorucki-tests-2.md
Outdated
| Test results shown in Testman are also sometimes incorrect, especially when a test spawns child processes. | ||
| I plan to fix these issues with Testman during my contract. | ||
|
|
||
| Eventually I would like to see our test bots become part of our CI/CD pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh.. they used to be 🙃 that reminds me to look at that colin mention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC it will show tests, but only when launched manually. Also it would always be green, so it's not really useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted the wording of this to say that I want the test bots to become more important in our CI/CD checks rather than it being in our CI/CD checks at all.
|
Regarding pictures: one thing I can think of is a comparison on Windows test results (the header with number of tests / failed tests) before and after your work. But that might be problematic because of the test bot rework and switch to x64 Vista. Anyway, if that looks good, you can include it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be an option to create a graph of the test fail/pass of the before and after?
(If that is not too much work!)
| title: "Progress update: fixing the ReactOS test suite" | ||
| author: "Carl Bialorucki" | ||
| date: 2025-11-04 | ||
| tags: [ "newsletter", "tests", "test-suite" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can whip something together in Excel. Direct Testman results may be hard since the search interface is so broken. |
Here's 2 comparisons:
Hard to compare due to changes to the runtime environment (new testbots, switch from x64 sk3 to vista) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have a small graphic on the main website where this is mentioned.

TODO