feat(core) add attachment/supdoc support#11
Open
JAertgeerts wants to merge 2 commits intored-coracle:masterfrom
Open
feat(core) add attachment/supdoc support#11JAertgeerts wants to merge 2 commits intored-coracle:masterfrom
JAertgeerts wants to merge 2 commits intored-coracle:masterfrom
Conversation
red-coracle
requested changes
Jun 13, 2024
Owner
red-coracle
left a comment
red-coracle
left a comment
There was a problem hiding this comment.
Thank you for the PR! Let me know if you see a reason not to use the default factories and I can add a test case as well.
JAertgeerts
force-pushed
the
feature/attachments
branch
from
c390029 to
90942f6
Compare
Author
hey! I've made the change, you're right to use the default factory 👍 . I've also added tests. |
JAertgeerts
force-pushed
the
feature/attachments
branch
2 times, most recently
from
810445c to
d8a154f
Compare
red-coracle
force-pushed
the
feature/attachments
branch
from
d8a154f to
27c407e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this provides support to create attachments / sup_docs
https://developer.intacct.com/api/company-console/attachments/#create-attachment-legacy