-
Notifications
You must be signed in to change notification settings - Fork 316
KFLUXINFRA-2591: Don't use default namespace in ArgoCD apps #9247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KFLUXINFRA-2591: Don't use default namespace in ArgoCD apps #9247
Conversation
🤖 Gemini AI Assistant AvailableHi @gbenhaim! I'm here to help with your pull request. You can interact with me using the following commands: Available Commands
How to Use
PermissionsOnly OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage. This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance. |
|
🤖 Hi @gbenhaim, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
oswcab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
ArgoCD started to complain about application that specify the default namespace in their manifest. This change won't change the actual namespace services are deployed to, since we already mentioned the namespace as part of the kustomization for all of them. Signed-off-by: Gal Ben Haim <gbenhaim@redhat.com>
12593ee to
b7ba33b
Compare
oswcab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbenhaim, oswcab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
argo-cd-apps/base/all-clusters/infra-deployments/authentication/authentication.yaml
Show resolved
Hide resolved
|
/lgtm |
|
/test |
|
@gbenhaim: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
a4d300e
into
redhat-appstudio:main
ArgoCD started to complain about application that specify the default namespace in their manifest. This change won't change the actual namespace services are deployed to, since we already mentioned the namespace as part of the kustomization for all of them.