Skip to content

Conversation

@josephdrichard
Copy link
Contributor

Add support for setting OS clock sync state based on information from chronyd. More specifically, when chronyd is controlling the OS clock, then the OS clock sync state should be reported as locked.

Also add basic unit tests for this.

Add support for setting OS clock sync state based on information from
chronyd.  More specifically, when chronyd is controlling the OS clock,
then the OS clock sync state should be reported as locked.

Also add basic unit tests for this.
@openshift-ci openshift-ci bot requested review from jzding and vitus133 December 11, 2025 18:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephdrichard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@josephdrichard josephdrichard changed the title support for chronyd metrics and events OCPBUGS-67237: support for chronyd metrics and events Dec 11, 2025
@openshift-ci-robot
Copy link

@josephdrichard: This pull request references Jira Issue OCPBUGS-67237, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-67236 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Add support for setting OS clock sync state based on information from chronyd. More specifically, when chronyd is controlling the OS clock, then the OS clock sync state should be reported as locked.

Also add basic unit tests for this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@josephdrichard josephdrichard changed the title OCPBUGS-67237: support for chronyd metrics and events OCPBUGS-67237: Ntpfailover backport 419 Dec 11, 2025
@josephdrichard
Copy link
Contributor Author

/retest

@josephdrichard
Copy link
Contributor Author

/verified later @klaskosk

@openshift-ci-robot
Copy link

@josephdrichard: This PR has been marked to be verified later by @klaskosk.

Details

In response to this:

/verified later @klaskosk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2025

@josephdrichard: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 3dd84a9 link true /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@josephdrichard
Copy link
Contributor Author

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants