-
Notifications
You must be signed in to change notification settings - Fork 347
Making the RemoveEnv method work across all containers in a deployment #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Making the RemoveEnv method work across all containers in a deployment #1003
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @AdamSaleh. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
eef6dde to
aa8b86c
Compare
|
/retest |
1 similar comment
|
/retest |
aa8b86c to
75cdcc6
Compare
…container in a deployment. Signed-off-by: Adam Saleh <adam@asaleh.net>
75cdcc6 to
4a1c437
Compare
|
/lgtm |
|
/lgtm |
Making the RemoveEnv method work across all containers in a deployment, instead asserting there is exactly one container.
What type of PR is this?
/kind failing-test
What does this PR do / why we need it:
When installing gitops-operator-bundle directly through operator sdk, there seems to be more than one container in the deployment. Making the utility function work across all containers makes the code more robust.