Skip to content

Conversation

@trdoyle81
Copy link
Contributor

@trdoyle81 trdoyle81 commented Dec 16, 2025

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind enhancement

What does this PR do / why we need it:
This PR adds a new e2e test, porting the 1-086_validate_applicationset_extra_command_args test to Ginkgo

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-7203

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:
to execute test locally
$ export LOCAL_RUN=true && export GINKGO_TEST_SUITE="parallel" && export export GINKGO_FOCUS="1-086_validate_applicationset_extra_command_args"
$ ./bin/ginkgo -v -focus $GINKGO_FOCUS -r ./test/openshift/e2e/ginkgo/$GINKGO_TEST_SUITE

@openshift-ci openshift-ci bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process. kind/failing-test Categorizes issue or PR as related to a frequently failing test. kind/enhancement New feature or request labels Dec 16, 2025
@openshift-ci openshift-ci bot requested review from jgwest and keithchong December 16, 2025 13:16
@openshift-ci
Copy link

openshift-ci bot commented Dec 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jgwest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Triona Doyle <bot@example.com>
@trdoyle81 trdoyle81 force-pushed the GITOPS-7203-Port-1-086_validate_applicationset_extra_command_args branch from 4d79145 to 49dbe4e Compare December 16, 2025 13:17
@trdoyle81 trdoyle81 removed kind/failing-test Categorizes issue or PR as related to a frequently failing test. kind/cleanup Categorizes issue or PR as related to cleaning up code, process. labels Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant