ImagePullPolicy support for GitOps Service #992
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @alkakumari016. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@alkakumari016: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
There was a problem hiding this comment.
Thanks @alkakumari016. Left few comments but overall looks good.
There was a problem hiding this comment.
Can we add a IT for IMAGE_PULL_POLICY env var?
Signed-off-by: Alka Kumari <alkumari@redhat.com>
Signed-off-by: Alka Kumari <alkumari@redhat.com>
Signed-off-by: Alka Kumari <alkumari@redhat.com>
Signed-off-by: Alka Kumari <alkumari@redhat.com>
alkakumari016
force-pushed
the
imagePullPolicy_gitopsService
branch
from
a86648f to
9b3ea41
Compare
|
/retest |
| // 1. CR-level override (highest precedence) | ||
| // 2. Environment variable (middle precedence) | ||
| // 3. Default fallback (lowest precedence - IfNotPresent) | ||
| func GetImagePullPolicy(crImagePullPolicy corev1.PullPolicy) corev1.PullPolicy { |
There was a problem hiding this comment.
Can we import this func from argocd-operator instead of duplicating it here?
…nt to sequential folder Signed-off-by: Alka Kumari <alkumari@redhat.com>
Signed-off-by: Alka Kumari <alkumari@redhat.com>
Signed-off-by: Alka Kumari <alkumari@redhat.com>
|
@alkakumari016: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Alka Kumari <alkumari@redhat.com>
3 participants
What type of PR is this?
What does this PR do / why we need it:
This PR adds the support of configurable ImagePullPolicy through CR and env variable
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
GITOPS-8044
Test acceptance criteria:
How to test changes / Special notes to the reviewer: