Skip to content

chore(app-defaults): Add changeset for release#2799

Open
gashcrumb wants to merge 1 commit intoredhat-developer:mainfrom
gashcrumb:RHIDP-13042-prep
Open

chore(app-defaults): Add changeset for release#2799
gashcrumb wants to merge 1 commit intoredhat-developer:mainfrom
gashcrumb:RHIDP-13042-prep

Conversation

@gashcrumb
Copy link
Copy Markdown
Member

@gashcrumb gashcrumb commented Apr 16, 2026

Hey, I just made a Pull Request!

This change sets the package.json files for app-auth and app-integration to the correct initial value and adds a changeset value to create an initial release. This change also updates the backend's dependency on "app" to use the workspace locator instead of link.

related to RHIDP-13042

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@gashcrumb
chore(app-defaults): Add changeset for release
9ecd9c8 
This change sets the package.json files for app-auth and app-integration
to the correct initial value and adds a changeset value to create an
initial release.  This change also updates the backend's dependency on
"app" to use the workspace locator instead of link.
@rhdh-qodo-merge
Copy link
Copy Markdown

rhdh-qodo-merge bot commented Apr 16, 2026 •
edited
Loading

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)
🐞\ ⚙ Maintainability (1)

Grey Divider


Action required

1. Fixed-group bumps app-react 🐞 ⚙
Description 
Because app-defaults uses a Changesets fixed group for all "@red-hat-developer-hub/*" packages, this
changeset will also force a version bump/release of
@red-hat-developer-hub/backstage-plugin-app-react even though it isn’t listed. That produces a
release/version bump for app-react without an explicit changeset entry for that package in this PR.
Code

workspaces/app-defaults/.changeset/green-mangos-wonder.md[R1-4]

+---
+'@red-hat-developer-hub/backstage-plugin-app-integrations': patch
+'@red-hat-developer-hub/backstage-plugin-app-auth': patch
+---
Relevance

⭐⭐⭐ High

Fixed group @red-hat-developer-hub/* will bump app-react even if not listed; this is
accurate/relevant.

PR-#2557
PR-#2639
PR-#2642

ⓘ Recommendations generated based on similar findings in past PRs

Evidence 
The changeset releases two @red-hat-developer-hub/* packages, while the workspace’s Changesets
config fixes (locks) all @red-hat-developer-hub/* packages into a single version line; app-react
matches that pattern, so it will be pulled into the same version bump/release cycle despite not
being listed in the changeset file.

workspaces/app-defaults/.changeset/green-mangos-wonder.md[1-4]
workspaces/app-defaults/.changeset/config.json[1-13]
workspaces/app-defaults/plugins/app-react/package.json[1-4]

Agent prompt 
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
In `workspaces/app-defaults`, Changesets is configured with a fixed group for all `@red-hat-developer-hub/*` packages. With that configuration, versioning/releasing one package in the group will also version-bump the other group members (e.g. `@red-hat-developer-hub/backstage-plugin-app-react`). The current changeset only lists app-auth and app-integrations, so app-react will still be bumped without being explicitly represented in this changeset.

## Issue Context
- Fixed group config exists in the workspace changesets config.
- The new changeset only lists two scoped packages.

## Fix Focus Areas
Update the changeset (and/or fixed-group config) so the resulting Version Packages PR does not unexpectedly bump packages that aren’t represented by a changeset entry.

- workspaces/app-defaults/.changeset/green-mangos-wonder.md[1-4]
- workspaces/app-defaults/.changeset/config.json[1-13]
- workspaces/app-defaults/plugins/app-react/package.json[1-4]

### Concrete option (minimal, explicit)
Add `@red-hat-developer-hub/backstage-plugin-app-react` to the frontmatter of `green-mangos-wonder.md` with the appropriate bump type so it is explicitly included in the changeset output (and update the text if needed to avoid misleading release notes).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app bot commented Apr 16, 2026

Changed Packages

Package Name Package Path Changeset Bump Current Version
backend workspaces/app-defaults/packages/backend none v0.0.0
@red-hat-developer-hub/backstage-plugin-app-auth workspaces/app-defaults/plugins/app-auth patch v0.0.0
@red-hat-developer-hub/backstage-plugin-app-integrations workspaces/app-defaults/plugins/app-integrations patch v0.0.0

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 16, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rhdh-qodo-merge
Copy link
Copy Markdown

rhdh-qodo-merge bot commented Apr 16, 2026

Review Summary by Qodo

Add changeset and prepare plugins for initial release

✨ Enhancement

Grey Divider

Walkthroughs

Description 
• Add changeset for initial release of app-auth and app-integrations plugins
• Reset package versions to 0.0.0 for proper release management
• Update backend dependency to use workspace locator instead of link
• Introduces migrated auth and integration plugins for new frontend system
Diagram 
flowchart LR
  A["app-auth plugin"] --> C["Changeset entry"]
  B["app-integrations plugin"] --> C
  C --> D["Version 0.0.0"]
  E["Backend package.json"] --> F["workspace: locator"]
Loading

Grey Divider

File Changes

1. workspaces/app-defaults/.changeset/green-mangos-wonder.md ⚙️ Configuration changes +8/-0

Add changeset for plugin release

• Creates new changeset file for initial release
• Marks both app-auth and app-integrations as patch versions
• Documents migration of auth and integration plugins from old frontend system
• Includes improvements for error handling and test logging

workspaces/app-defaults/.changeset/green-mangos-wonder.md

2. workspaces/app-defaults/plugins/app-auth/package.json ⚙️ Configuration changes +1/-1

Reset app-auth version to 0.0.0

• Resets version from 1.0.0 to 0.0.0 for initial release
• Aligns with changeset versioning strategy

workspaces/app-defaults/plugins/app-auth/package.json

3. workspaces/app-defaults/plugins/app-integrations/package.json ⚙️ Configuration changes +1/-1

Reset app-integrations version to 0.0.0

• Resets version from 1.0.0 to 0.0.0 for initial release
• Aligns with changeset versioning strategy

workspaces/app-defaults/plugins/app-integrations/package.json

View more (1)
4. workspaces/app-defaults/packages/backend/package.json Dependencies +1/-1

Update app dependency to workspace locator

• Changes app dependency from link protocol to workspace locator
• Updates dependency resolution to use workspace:^ instead of link:../app
• Improves monorepo dependency management

workspaces/app-defaults/packages/backend/package.json

Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge bot added enhancement New feature or request Other labels Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03 rohitkrai03 is a code owner

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov christoph-jerolimov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request Other workspace/app-defaults

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gashcrumb