Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

@DuncanDoyle
Copy link

Fixed the ServiceBindingRequest YAML to use the proper "apiVersion" and "kind", and updated the "spec" to use "applicationSelector" and "backingServiceSelector".

Motivation

ServiceBinding YAML in the README does not work with latest ServiceBindingOperator.

Changes

YAML now use ServiceBindingRequest with correct "spec" ("applicationSelector" and "backingServiceSelector") instead of the "ServiceBinding"

Testing

Walk through the README and apply the YAML.

For further more details refer the CONTRIBUTING.md

Fixed the ServiceBindingRequest YAML to use the proper "apiVersion" and "kind", and updated the "spec" to use "applicationSelector" and "backingServiceSelector".
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign isutton after the PR has been reviewed.
You can assign the PR to them by writing /assign @isutton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Collaborator

Hi @DuncanDoyle. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Avni-Sharma
Copy link
Contributor

Hi @DuncanDoyle The API has changed and hence those apis. A reference for the same- #608

@Avni-Sharma
Copy link
Contributor

Closing PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants