Show actual step name in Error Logs Preview instead of generic category#92
Closed
mohit-sheth wants to merge 0 commit intoredhat-performance:mainfrom
Closed
Show actual step name in Error Logs Preview instead of generic category#92mohit-sheth wants to merge 0 commit intoredhat-performance:mainfrom
mohit-sheth wants to merge 0 commit intoredhat-performance:mainfrom
Conversation
Collaborator
|
Pre-requisite to consider before merging this: #93 |
Collaborator
|
Somehow I cannot see the file diff on this PR. But yeah, for change points we never had a Error Logs Preview. It was a bug that is fixed in the above PR. |
Collaborator
Author
|
closing as this was main branch 😓 |
Collaborator
Author
|
closing in favour of #94 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the real step name (e.g. orion-udn-l3) in the preview header instead of a generic description (e.g. orion changepoint detection failure), since many different steps share the same keyword.
Summary
Logs Preview"
step-name prefixes and linking directly to the HTML file when present
step_namethroughanalyze_prow_artifactsreturn tuple so callers can resolve the correct artifact pathfailure_desclogic into a shared_get_failure_desc()helper inSlackMessageFetcher