Skip to content

Hybrid VMs at large scale improvements#733

Merged
openshift-merge-bot[bot] merged 5 commits intoredhat-performance:mainfrom
afcollins:hv-hugepages
Feb 27, 2026
Merged

Hybrid VMs at large scale improvements#733
openshift-merge-bot[bot] merged 5 commits intoredhat-performance:mainfrom
afcollins:hv-hugepages

Conversation

@afcollins
Copy link
Member

@afcollins afcollins commented Oct 31, 2025

Enables hugepages on the hypervisor and libvirt VMs.
Fixes some issues with hugetlb pages.

Also, adds interfaces that can be used as virtual functions.

Some changes were generated using Cursor and the claude-4-sonnet model.

@akrzos akrzos requested a review from mcornea November 3, 2025 14:36
@afcollins
Copy link
Member Author

Addressed all comments. Reverted some unnecessary changes. Renamed a variable. Added a variable for VFs in VMs. Please take another look when you can.

I still don't have a way to validate these changes for right now. :/ But may be able to do so in early December.

@afcollins afcollins marked this pull request as draft January 30, 2026 05:15
@afcollins
Copy link
Member Author

Changing to draft while I split into more atomic PRs.

@afcollins afcollins changed the title Changes from 500 VMs Hybrid work Hybrid VMs at large scale improvements Feb 12, 2026
@mcornea
Copy link
Collaborator

mcornea commented Feb 18, 2026

Hi @afcollins Is this PR ready for merge?

Update the documentation.

Signed-off-by: Andrew Collins <ancollin@redhat.com>
Signed-off-by: Andrew Collins <ancollin@redhat.com>
This update enhances the usability and understanding of the deployment
process.

Co-Authored-By: Cursor agent, claude-4.6-opus model

Signed-off-by: Andrew Collins <ancollin@redhat.com>
@afcollins afcollins marked this pull request as ready for review February 26, 2026 18:26
@openshift-ci openshift-ci bot requested a review from rsevilla87 February 26, 2026 18:26
@afcollins
Copy link
Member Author

afcollins commented Feb 26, 2026

It is not quite ready yet.

The documentation was never finished, so I filled it out and reduced the complexity.

Rebased on main.

Seems memory isn't being calculated correctly, so I need to dig into it.

VM vm00001 will use 2 1Gi hugepages (2G total)

@afcollins afcollins marked this pull request as draft February 26, 2026 23:11
@afcollins
Copy link
Member Author

Figured it out. The vm_hugepage_count variable was used in the debug message.

After further review, the variable is only used for the message and the VM will take as many hugepages as required based on its defined memory. Therefore, I think it makes more sense to remove the variable entirely and only use the memory defined on the hv_vm host entry.

Tested and it works. Should be all good to go now.

TASK [hv-vm-create : Set hugepage count for VM] *******************************
Friday 27 February 2026  01:00:53 +0000 (0:00:00.015)       0:00:01.139 *******
ok: [vm00001]

TASK [hv-vm-create : Check host hugepages availability] ***********************
Friday 27 February 2026  01:00:53 +0000 (0:00:00.029)       0:00:01.169 *******
changed: [vm00001 -> e35-......com]

TASK [hv-vm-create : Validate sufficient hugepages available] *****************
Friday 27 February 2026  01:00:54 +0000 (0:00:00.738)       0:00:01.908 *******
skipping: [vm00001]

TASK [hv-vm-create : Display hugepages configuration for VM] ******************
Friday 27 February 2026  01:00:54 +0000 (0:00:00.026)       0:00:01.934 *******
ok: [vm00001] => {
    "msg": "VM vm00001 will use 18 1Gi hugepages (18G total)"
}

@afcollins afcollins marked this pull request as ready for review February 27, 2026 01:06
@openshift-ci openshift-ci bot requested a review from mcornea February 27, 2026 01:06
@mcornea
Copy link
Collaborator

mcornea commented Feb 27, 2026

Awesome, thanks @afcollins !

@mcornea
Copy link
Collaborator

mcornea commented Feb 27, 2026

/lgtm

@mcornea
Copy link
Collaborator

mcornea commented Feb 27, 2026

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mcornea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 29d79d8 into redhat-performance:main Feb 27, 2026
1 check passed
@afcollins afcollins deleted the hv-hugepages branch February 27, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants